Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Fix default diam distr #83

Merged
merged 4 commits into from
Sep 13, 2023
Merged

Feat: Fix default diam distr #83

merged 4 commits into from
Sep 13, 2023

Conversation

arnaudon
Copy link
Contributor

Fixing the mistakes of PR #47

neurots/schemas/distributions.json Outdated Show resolved Hide resolved
neurots/schemas/distributions.json Outdated Show resolved Hide resolved
neurots/schemas/distributions.json Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #83 (34f3a4c) into main (4249ee9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #83   +/-   ##
=======================================
  Coverage   97.69%   97.69%           
=======================================
  Files          39       39           
  Lines        2165     2166    +1     
  Branches      372      373    +1     
=======================================
+ Hits         2115     2116    +1     
  Misses         30       30           
  Partials       20       20           
Flag Coverage Δ
pytest 97.69% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
neurots/extract_input/input_distributions.py 100.00% <100.00%> (ø)
neurots/extract_input/input_parameters.py 97.56% <100.00%> (+0.12%) ⬆️

@arnaudon
Copy link
Contributor Author

@adrien-berchet , good to merge and release?

Copy link
Member

@adrien-berchet adrien-berchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Did you test it in region-grower and synthesis-workflow?

@arnaudon
Copy link
Contributor Author

Cool, I am fixing them atm and checking!

@arnaudon arnaudon merged commit 39d6026 into main Sep 13, 2023
9 checks passed
@arnaudon arnaudon deleted the fix_diam branch September 13, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants