Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Allow for normal orientation with basals #90

Merged
merged 5 commits into from
Sep 28, 2023
Merged

Conversation

arnaudon
Copy link
Contributor

No description provided.

@arnaudon
Copy link
Contributor Author

The test values are different, just because of the call to sample.n_neurites which shifts the random numbers.

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #90 (c351bf5) into main (5e8fe6a) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #90   +/-   ##
=======================================
  Coverage   97.71%   97.72%           
=======================================
  Files          39       39           
  Lines        2191     2197    +6     
  Branches      380      382    +2     
=======================================
+ Hits         2141     2147    +6     
  Misses         30       30           
  Partials       20       20           
Flag Coverage Δ
pytest 97.72% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
neurots/generate/orientations.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

neurots/generate/orientations.py Outdated Show resolved Hide resolved
@arnaudon arnaudon merged commit 69be242 into main Sep 28, 2023
9 checks passed
@arnaudon arnaudon deleted the fix_orientation_basal branch September 28, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants