This repository has been archived by the owner on Jan 29, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #576.
Description
bbs_database add
is now filtering and keeping the articles not already present in the database (thanks touid
) before adding them.Discussion
new
articles (=articles whoseuid
does not exist in the database), should weconftest.py
is inspired by thecovid-19
database schema. Should we create a new database representing our future database ?test_sql
contains a test checking that we do not have anySQL
query outside of thesql
module. We never updated this test after adding new modules. Should we do something about this ?articles
? Currently we parse everything and then save all articles. Should we create batch ? Save articles one by one ?Checklist
(if it is not the case, please create an issue first).
(if needed)
whatsnew.rst
updated.(if needed)
setup.py
andrequirements.txt
updated with new dependencies.(if needed)
(if a function is added or modified)