This repository has been archived by the owner on Jan 29, 2024. It is now read-only.
feature/add-abstract-to-paragraphs-table #639
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drsantos89
requested review from
EmilieDel,
FrancescoCasalegno and
jankrepl
jankrepl
reviewed
Oct 3, 2022
| for ppos, (section, text) in enumerate(article.section_paragraphs): | ||
| doc = { | ||
| "_index": "paragraphs", | ||
| "_source": { | ||
| "article_id": article.uid, | ||
| "section_name": section, | ||
| "section": section, | ||
| "text": text, | ||
| "paragraph_id": ppos, |
There was a problem hiding this comment.
If I remember correctly, the goal of this paragraph_id is to hold a unique number (just an increment integer) for each paragraph. However, if I am not mistaken after introduction of the abstract paragraphs into the paragraphs table we might have collisions
There was a problem hiding this comment.
I agree, maybe we could put "paragraph_id": ppos + i + 1 to avoid any collisions. What do you think @drsantos89 @jankrepl ?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #637.
Description
Adds the abstract to the paragraphs table so it can be searchable using semantic search.
How to test?
Abstract field added to the tests/unit/entrypoint/database/test_add_es.py
Checklist
(if it is not the case, please create an issue first).
(if needed)
whatsnew.rstupdated.(if needed)
setup.pyandrequirements.txtupdated with new dependencies.(if needed)
(if a function is added or modified)