Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Better config handling for combos #30

Merged
merged 6 commits into from
Jan 24, 2024
Merged

Feat: Better config handling for combos #30

merged 6 commits into from
Jan 24, 2024

Conversation

arnaudon
Copy link
Collaborator

No description provided.

@arnaudon arnaudon marked this pull request as ready for review January 24, 2024 12:50
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (1674cc1) 31.41% compared to head (0b69584) 39.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   31.41%   39.61%   +8.20%     
==========================================
  Files          22       22              
  Lines        5828     5838      +10     
  Branches     1117     1120       +3     
==========================================
+ Hits         1831     2313     +482     
+ Misses       3786     3249     -537     
- Partials      211      276      +65     
Flag Coverage Δ
pytest 39.61% <60.00%> (+8.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
emodel_generalisation/model/access_point.py 54.73% <0.00%> (ø)
emodel_generalisation/model/nexus_converter.py 84.54% <93.75%> (-7.05%) ⬇️
emodel_generalisation/cli.py 71.63% <23.07%> (-0.99%) ⬇️

... and 10 files with indirect coverage changes

@arnaudon arnaudon merged commit 74a9d25 into main Jan 24, 2024
6 checks passed
@arnaudon arnaudon deleted the configv2 branch January 24, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants