Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Make sure param in final works #36

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Fix: Make sure param in final works #36

merged 1 commit into from
Feb 9, 2024

Conversation

arnaudon
Copy link
Collaborator

@arnaudon arnaudon commented Feb 9, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (cc2e462) 37.87% compared to head (9221704) 37.24%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
- Coverage   37.87%   37.24%   -0.63%     
==========================================
  Files          23       23              
  Lines        6245     6248       +3     
  Branches     1215     1216       +1     
==========================================
- Hits         2365     2327      -38     
- Misses       3599     3643      +44     
+ Partials      281      278       -3     
Flag Coverage Δ
pytest 37.24% <33.33%> (-0.63%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
emodel_generalisation/model/bpopt.py 74.27% <ø> (ø)
emodel_generalisation/model/evaluation.py 50.35% <33.33%> (-0.15%) ⬇️

... and 2 files with indirect coverage changes

@arnaudon arnaudon merged commit b17d82e into main Feb 9, 2024
6 checks passed
@arnaudon arnaudon deleted the small_things branch February 9, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants