Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add favicon to public folder #1454

Merged
merged 5 commits into from
Jan 9, 2024
Merged

Conversation

bilalesi
Copy link
Contributor

@bilalesi bilalesi commented Jan 8, 2024

Add favicon icon to public folder

Description

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

@bilalesi bilalesi requested review from smitfire and Dinika January 8, 2024 12:56
@bilalesi bilalesi self-assigned this Jan 8, 2024
@danburonline
Copy link
Contributor

image

I suggest using an .ico file instead of a .png for the favicon to support multiple sizes. The current icon (see screenshot) lacks the desired quality and also doesn't look much like "an icon". It would be beneficial to create a manifest file with various sizes, too! I recommend using PWABuilder to quickly generate these files.

PS: This will allow Fusion to be installed as a PWA.

@bilalesi
Copy link
Contributor Author

bilalesi commented Jan 9, 2024

image I suggest using an `.ico` file instead of a `.png` for the favicon to support multiple sizes. The current icon (see screenshot) lacks the desired quality and also doesn't look much like "an icon". It would be beneficial to create a manifest file with various sizes, too! I recommend using [PWABuilder](https://www.pwabuilder.com/) to quickly generate these files.

PS: This will allow Fusion to be installed as a PWA.

Thanks daniel, feedback implemented (since the app only running in desktop, i generate the favicons only for that )

@bilalesi bilalesi merged commit 12728f7 into fusion-react-18-vite Jan 9, 2024
5 checks passed
@bilalesi bilalesi deleted the chore/add-favicon branch January 9, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants