Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: table ref is not the same as v4 #1470

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

bilalesi
Copy link
Contributor

Apparently the last version of ANTD is not passing the table container element which is div as ref, so it breaks some use of it, I change the type of the ref using ElementRef<typeof Table> that contains { nativeElemet, scrollTo }
everything else stay the same, also fixed some style regression which is not perfect too but will create another ticket

Description

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

@bilalesi bilalesi self-assigned this Jan 10, 2024
@bilalesi bilalesi merged commit ba221b7 into fusion-react-18-vite Jan 10, 2024
5 checks passed
@bilalesi bilalesi deleted the fix/data-explorer-issue-due-antd-v5 branch January 10, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants