Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration/fix Query Editor line jumping #1514

Merged
merged 6 commits into from
Mar 7, 2024

Conversation

danburonline
Copy link
Contributor

@danburonline danburonline commented Feb 26, 2024

When trying to edit a query or create a new one, the active line jumps to the last line if you type. This PR fixes this issue.

comparison

Additionally:

  • Cleaned and refactored touched components.
  • Adjusted styles a bit.
  • Moved the "Execute Elasticsearch query" button to the top right, as is the case with other code editor buttons in the Fusion app.

How has this been tested?

  • Tested locally with dev server and prod build on my MacBook.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have added screenshots (if applicable), in the comment section.

@danburonline danburonline self-assigned this Feb 26, 2024
@danburonline danburonline changed the base branch from main to migration-merge February 26, 2024 06:09
@danburonline danburonline marked this pull request as ready for review February 26, 2024 13:29
@danburonline danburonline mentioned this pull request Feb 26, 2024
18 tasks
@danburonline danburonline merged commit fc55b66 into migration-merge Mar 7, 2024
4 of 5 checks passed
@danburonline danburonline deleted the migration/fix/line-editing branch March 7, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants