Fix pdf viewer for analysis plugin #1549
Merged
+394
−284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The newer version of react-pdf needd to wait for the pdf Document to be loaded before the Page is displayed.
smitfire
approved these changes
Nov 6, 2024
As suggested here the react-pdf workers use functions that are not availalbe on older node versions elizaOS/eliza#76 Signed-off-by: Dinika Saxena <dinikasaxenas@gmail.com>
Signed-off-by: Dinika Saxena <dinikasaxenas@gmail.com>
Dinika
force-pushed
the
fix-analysis-plugin
branch
from
217d723 to
2241e63
Compare
Dinika
force-pushed
the
fix-analysis-plugin
branch
from
a156e5e to
2875b7c
Compare
Signed-off-by: Dinika Saxena <dinikasaxenas@gmail.com>
Dinika
force-pushed
the
fix-analysis-plugin
branch
from
2875b7c to
ee4ec05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is needed to complete the react migration.
The Analysis plugin cypress test was failing because the Analysis plugin was not working.
The plugin was not working because
react-pdfwas not able to render pdf.To make the rendering work these changes were needed:
Documentto be ready before rendering thePageHow has this been tested?
Types of changes
Checklist: