Fix build issue on Apple M1 with AppleClang #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pramodk
force-pushed
the
pramodk/apple-m1-fix
branch
from
f77943d to
504a078
Compare
nrnhines
reviewed
Feb 27, 2021
iomaganaris
approved these changes
Mar 2, 2021
- Currently catch2 is header directly added in the project - Before switching to submodule (in separate PR), copying minimal fix from the upstream: catchorg/Catch2#1971 - Update INSTALL.md for Apple M1 Fixes #527
pramodk
force-pushed
the
pramodk/apple-m1-fix
branch
from
504a078 to
6359fea
Compare
Codecov Report
@@ Coverage Diff @@
## master #528 +/- ##
=======================================
Coverage 55.39% 55.39%
=======================================
Files 199 199
Lines 32098 32098
=======================================
Hits 17781 17781
Misses 14317 14317 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minimal fix from the upstream: Fix for macOS on ARM catchorg/Catch2#1971
Fixes #527