Reorganise "global" variables to not be global #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
10 tasks
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
pramodk
reviewed
Aug 11, 2022
This comment was marked as outdated.
This comment was marked as outdated.
pramodk
reviewed
Aug 11, 2022
olupton
force-pushed
the
olupton/global-variables
branch
from
09005d9
to
d44340f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
olupton
force-pushed
the
olupton/global-variables
branch
from
d44340f
to
22361bd
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Logfiles from GitLab pipeline #70967 (:no_entry:) have been uploaded here! Status and direct links: |
|
Logfiles from GitLab pipeline #71003 (:white_check_mark:) have been uploaded here! Status and direct links: |
|
Logfiles from GitLab pipeline #71039 (:white_check_mark:) have been uploaded here! Status and direct links: |
pramodk
approved these changes
Aug 25, 2022
|
Logfiles from GitLab pipeline #71265 (:no_entry:) have been uploaded here! Status and direct links: |
|
Logfiles from GitLab pipeline #71277 (:white_check_mark:) have been uploaded here! Status and direct links: |
olupton
force-pushed
the
olupton/global-variables
branch
2 times, most recently
from
c7891c5
to
4eaad0b
Compare
olupton
force-pushed
the
olupton/global-variables
branch
from
4eaad0b
to
0274a4c
Compare
|
Logfiles from GitLab pipeline #71295 (:white_check_mark:) have been uploaded here! Status and direct links: |
iomaganaris
reviewed
Aug 26, 2022
pramodk
added a commit
to BlueBrain/CoreNeuron
that referenced
this pull request
Aug 28, 2022
…#795) * coreneuron and mechanism library can be built as shared and it enables launching coreneuron on GPU via python * update MOD2C and NMODL fixes to handle GLOBAL variables See BlueBrain/mod2c/pull/78 See BlueBrain/nmodl/pull/904 * removed acc/openmp global annotations for celsius, pi and secondorder and they don't need to be copied on GPU * Pass Memb_list* as an argument for all common prototypes in order to support global variables via argument * free ml->instance if not empty * add link to libscopmath in neuron as well * nrn_ghk is now declared inline. * homegrown present table to avoid dynamic loading + acc_deviceptr limitations * use -gpu=nordc and make #pragma acc routine seq functions inline * drop -lscopmath as its folded in elsewhere * random123 header reorganisation * try and cleanup CLI11 handling. * try and consolidate build logic * some CORENEURON_ -> CORENRN_ for consistency. * export OpenACC flags to NEURON separately as well as part of the whole ... -lcoreneuron ... link line. * libcoreneuron.so -> libcorenrnmech.so, try and fix static builds * do not enable OpenMP in shared/OpenACC builds. * add rpaths inside nrnivmodl-core. * accept a private destructor function pointer from generated mechanisms * drop ${TEST_EXEC_PREFIX} that was causing simple tests to be executed on many ranks. * CORENEURON_GPU_DEBUG: add environment variable that enables cnrn_target_* debug messages. fixes #141 Co-authored-by: Olli Lupton <oliver.lupton@epfl.ch>
pramodk
added a commit
to neuronsimulator/nrn
that referenced
this pull request
Nov 2, 2022
…BlueBrain/CoreNeuron#795) * coreneuron and mechanism library can be built as shared and it enables launching coreneuron on GPU via python * update MOD2C and NMODL fixes to handle GLOBAL variables See BlueBrain/mod2c/pull/78 See BlueBrain/nmodl/pull/904 * removed acc/openmp global annotations for celsius, pi and secondorder and they don't need to be copied on GPU * Pass Memb_list* as an argument for all common prototypes in order to support global variables via argument * free ml->instance if not empty * add link to libscopmath in neuron as well * nrn_ghk is now declared inline. * homegrown present table to avoid dynamic loading + acc_deviceptr limitations * use -gpu=nordc and make #pragma acc routine seq functions inline * drop -lscopmath as its folded in elsewhere * random123 header reorganisation * try and cleanup CLI11 handling. * try and consolidate build logic * some CORENEURON_ -> CORENRN_ for consistency. * export OpenACC flags to NEURON separately as well as part of the whole ... -lcoreneuron ... link line. * libcoreneuron.so -> libcorenrnmech.so, try and fix static builds * do not enable OpenMP in shared/OpenACC builds. * add rpaths inside nrnivmodl-core. * accept a private destructor function pointer from generated mechanisms * drop ${TEST_EXEC_PREFIX} that was causing simple tests to be executed on many ranks. * CORENEURON_GPU_DEBUG: add environment variable that enables cnrn_target_* debug messages. fixes BlueBrain/CoreNeuron#141 Co-authored-by: Olli Lupton <oliver.lupton@epfl.ch> CoreNEURON Repo SHA: BlueBrain/CoreNeuron@12272f8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See BlueBrain/CoreNeuron#795 and BlueBrain/mod2c#78.
TODO:
nvc++ -cuda--> https://gitlab.com/libeigen/eigen/-/merge_requests/1041Print a warning if an external fmt is used with nvhpc 22.3?--> Update fmt submodule #914CI_BRANCHES:CORENEURON_BRANCH=pramodk/exclude-global-vars,NEURON_BRANCH=olupton/coreneuron-gpu-dynamic-loading