Skip to content

Commit

Permalink
BUG: Do not adjust Phase values in CTF Files
Browse files Browse the repository at this point in the history
Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
  • Loading branch information
imikejackson committed May 13, 2024
1 parent 4ac8816 commit 412ae98
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 17 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -515,24 +515,7 @@ void ReadCtfData::copyRawEbsdData(CtfReader* reader, std::vector<size_t>& tDims,
tDims[2] = m->getGeometryAs<ImageGeom>()->getZPoints();
ebsdAttrMat->resizeAttributeArrays(tDims);
{
/* Take from H5CtfVolumeReader.cpp
* For HKL OIM Files if there is a single phase then the value of the phase
* data is one (1). If there are 2 or more phases then the lowest value
* of phase is also one (1). However, if there are "zero solutions" in the data
* then those points are assigned a phase of zero. Since those points can be identified
* by other methods, the phase of these points should be changed to one since in the rest
* of the reconstruction code we follow the convention that the lowest value is One (1)
* even if there is only a single phase. The next if statement converts all zeros to ones
* if there is a single phase in the OIM data.
*/
phasePtr = reinterpret_cast<int32_t*>(reader->getPointerByName(EbsdLib::Ctf::Phase));
for(size_t i = 0; i < totalPoints; i++)
{
if(phasePtr[i] < 1)
{
phasePtr[i] = 1;
}
}
iArray = Int32ArrayType::CreateArray(totalPoints, SIMPL::CellData::Phases, true);
::memcpy(iArray->getPointer(0), phasePtr, sizeof(int32_t) * totalPoints);
ebsdAttrMat->insertOrAssign(iArray);
Expand Down
1 change: 1 addition & 0 deletions Website/docs/Latest_Release_Notes.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ hide:
## Known Issues ##

- Match Crystallography: The Average Quaternions that are generated may not be correct. As a work around, use the "Delete Data" filter to remove the FeatureData / Average Quaternions and then regenerate them by using the "Convert Orientation Representation" filter to convert the Average Euler Angles to Quaternions.
- Read Oxford Instruments CTF File: There is an issue where the phase data values will be incremented from 0 to 1 under certain conditions. The workaround is to first convert the data to an H5EBSD file, then read the data from the H5EBSD file in DREAM.3D.

## Version 6.5.171 Release Notes ##

Expand Down

0 comments on commit 412ae98

Please sign in to comment.