-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for EXTERNAL auth without uid #193
Conversation
Codecov ReportBase: 82.28% // Head: 82.38% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #193 +/- ##
==========================================
+ Coverage 82.28% 82.38% +0.09%
==========================================
Files 27 27
Lines 3162 3167 +5
Branches 652 654 +2
==========================================
+ Hits 2602 2609 +7
+ Misses 343 342 -1
+ Partials 217 216 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
All done. Should we try to fall back to this method if the default method with the uid from |
I think its probably fine without it |
This looks good. Would you update the doc string below as well?
|
It is currently the only reason I'm patching the Home Assistant docker image locally... |
Isn't that silently hiding an issue, it might not be the behavior the caller wants? |
Tested 👍 |
As a follow-up to #188 , this PR allows
EXTERNAL
auth without a uid as per RFC4422. If we pass-1
as the uid, it will trigger the following auth sequence (source: https://gitlab.freedesktop.org/dbus/dbus/-/issues/195):The upside of this is that when running in a user namespace (e.g. rootless docker), we don't need to know our uid mapping outside of the namespace to connect to the system dbus on the host.