feat!: don't import backends by default #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #243 +/- ##
==========================================
+ Coverage 82.81% 82.84% +0.03%
==========================================
Files 28 28
Lines 3259 3259
Branches 674 674
==========================================
+ Hits 2699 2700 +1
+ Misses 343 342 -1
Partials 217 217
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
|
Technically, this is an API breaking change, but I think the only thing it would break is: import dbus_fast
dbus_fast.aio.somethingor from dbus_fast import *
aio.somethingwhich I hope would be quite rare. |
|
We should probably mark it as a breaking change. Testing this now |
dlech
force-pushed
the
no-backend-import
branch
from
0a7dbb1 to
b86dd85
Compare
BREAKING CHANGE: Since the top-level `__init__.py` is always imported when any subpackage is imported, this caused both backends (glib and aio) to always be imported. This is not desirable, since it means that the glib backend will always be imported, even if the user only wants to use the aio. This wastes resources and in some cases can even cause a crash. Fixes: #242
dlech
force-pushed
the
no-backend-import
branch
from
b86dd85 to
d2a0104
Compare
bdraco
changed the title
bdraco
approved these changes
Sep 7, 2023
|
Pushed to all my production. Nothing broke. Let's hope thats the case for everyone else |
|
Thanks @dlech |
|
Everything was ok with the dep bump except
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the top-level
__init__.pyis always imported when any subpackage is imported, this caused both backends (glib and aio) to always be imported. This is not desirable, since it means that the glib backend will always be imported, even if the user only wants to use the aio. This wastes resources and in some cases can even cause a crash.Fixes: #242