Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: precision loss when comparing advs from different sources #136

Merged
merged 4 commits into from
Feb 1, 2025

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Feb 1, 2025

stale_seconds should have been a double

Copy link

codecov bot commented Feb 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.05%. Comparing base (69168a6) to head (e1a82ef).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #136   +/-   ##
=======================================
  Coverage   84.05%   84.05%           
=======================================
  Files          12       12           
  Lines        1217     1217           
  Branches      140      140           
=======================================
  Hits         1023     1023           
  Misses        145      145           
  Partials       49       49           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Feb 1, 2025

CodSpeed Performance Report

Merging #136 will not alter performance

Comparing fix_precision_loss (e1a82ef) with main (69168a6)

Summary

✅ 3 untouched benchmarks

@bdraco bdraco merged commit 02279a9 into main Feb 1, 2025
26 of 27 checks passed
@bdraco bdraco deleted the fix_precision_loss branch February 1, 2025 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant