Skip to content

Commit

Permalink
Remove multidex library (apollographql#5930)
Browse files Browse the repository at this point in the history
  • Loading branch information
martinbonnin authored and BoD committed Jul 1, 2024
1 parent c0e08f8 commit 5f3baef
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 6 deletions.
2 changes: 0 additions & 2 deletions build-logic/src/main/kotlin/Android.kt
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,4 @@ fun Project.configureAndroid(
}
}
}

dependencies.add("implementation", getCatalogLib("androidx.multidex"))
}
1 change: 0 additions & 1 deletion gradle/libraries.toml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ androidx-core = "androidx.core:core-ktx:1.12.0"
androidx-espresso-idlingresource = { group = "androidx.test.espresso", name = "espresso-idling-resource", version = "3.5.1" }
androidx-lint-rules = "androidx.lint:lint-gradle:1.0.0-alpha01"
androidx-lint-gradle-plugin = { module = "com.android.lint:com.android.lint.gradle.plugin", version.ref = "android-plugin" }
androidx-multidex = "androidx.multidex:multidex:2.0.1"
androidx-paging-compose = "androidx.paging:paging-compose:1.0.0-alpha18"
androidx-profileinstaller = "androidx.profileinstaller:profileinstaller:1.3.1"
androidx-sqlite = { group = "androidx.sqlite", name = "sqlite", version.ref = "androidx-sqlite" }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import com.apollographql.apollo3.mockserver.enqueueString
import com.apollographql.apollo3.network.NetworkMonitor
import com.apollographql.apollo3.network.http.DefaultHttpEngine
import com.apollographql.apollo3.network.http.HttpEngine
import com.apollographql.apollo3.testing.FooOperation
import com.apollographql.apollo3.testing.FooQuery
import com.apollographql.apollo3.testing.mockServerTest
import kotlin.test.Test
import kotlin.test.assertEquals
Expand Down Expand Up @@ -43,9 +43,9 @@ class NetworkMonitorTest {
httpEngine(FaultyHttpEngine())
}
) {
mockServer.enqueueString(FooOperation.successResponse)
mockServer.enqueueString(FooQuery.successResponse)

val response = apolloClient.query(FooOperation()).execute()
val response = apolloClient.query(FooQuery()).execute()

assertEquals(42, response.data?.foo)

Expand Down

0 comments on commit 5f3baef

Please sign in to comment.