Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to Build 3095 Chop Shop DLC #130

Closed
wants to merge 11 commits into from
Closed

Conversation

ItzCelyrian
Copy link

Added LICENSE.md (Non-Commerical 4.0)
Added 3095 - Chop Shop DLC
Added 2189 - Cayo Perico DLC
Fixed routing on Cayo Perico (Waypoints work if the player is on the island)
Fixed Minimap of Cayo Perico

TODO:

  • In my servers case this wasn't necessairy but currently on Version: "3.0a" the loading of 2189 and 3095 is permanently enabled, this will need to be added to client.lua in order to allow disabling of elements.

@ItzCelyrian
Copy link
Author

ItzCelyrian commented Jan 8, 2024

In this PR the following files should be updated and/or ignored/adjusted.

Since I will be forking this into my own Loader I just wanted to contribute the changes I made up to 3095.

The changes which you might want to revert are found within:

  • README.md (Since linkage works to my repository on my branch.)
  • fxmanifest.lua (I added myself to the Authors inside my repository, you can remove this from the PR by cherry picking.)
  • LICENSE.md can be scrapped, if you wish to do so.

@ItzCelyrian ItzCelyrian mentioned this pull request Jan 8, 2024
Copy link

@QuirkyCarlos QuirkyCarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested myself on my dev server literally can just drag into bob_ipl folder fine

@Virus18sp
Copy link

Will you add support for 2944 too? there are some good interiors.

@ItzCelyrian
Copy link
Author

@Virus18sp I will create a new Version on my fork, continue tests with 2944 and then if it goes well add them to the Pull Request.👍

@ItzCelyrian
Copy link
Author

ItzCelyrian commented Jan 15, 2024

@Virus18sp

  • Added San Andreas Mercenary (2944)
  • Added Summer Special (- [Arcade])

@Sina30
Copy link

Sina30 commented Feb 23, 2024

You shouldn't use it yet because it only causes problems at the casinos, and it also only causes problems near the harbor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove the wiki reference?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the Readme redirect to my Repo. That is why I recommended a Cherry-Pick merge.

Copy link
Collaborator

@TheIndra55 TheIndra55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry but this does not follow the code structure of this project at all. I'll reimplement these changes myself in another PR.

@TheIndra55
Copy link
Collaborator

Closing this since the latest DLCs have been added in #133.

There's still some stuff missing like arcades and cayo, but don't be hesitant to open a pull request for those. Please do follow the existing code.

@TheIndra55 TheIndra55 closed this Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants