Fix: Remove Citizen. to bring format up-to-date #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unnecessary Citizen. to bring things up to date with current practices in the FiveM community. Replaced: Citizen.CreateThread Citizen. Wait Citizen.Trace
TheIndra55
reviewed
Aug 10, 2024
|
What does this benefit compared to the old way? Curious for other older scripts we run if its worth doing the same. |
It's mostly a "best practice" type change. Maybe some insanely minor performance improvement no one could detect. I think https://docs.fivem.net/docs/scripting-reference/runtimes/lua/functions/Citizen.Await is the only thing that needs Citizen. |
TheIndra55
approved these changes
Aug 11, 2024
|
Thanks for your contribution :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary Citizen. to bring things up to date with current practices in the FiveM community.
Replaced:
Citizen.CreateThread
Citizen. Wait
Citizen.Trace