Optimize stackalloc in FirstBy, GatherBy

Bobris · Dec 27, 2024 · 7399f3f · 7399f3f
1 parent 3483e8c
commit 7399f3f
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/BTDB/ODBLayer/RelationDBManipulator.cs b/BTDB/ODBLayer/RelationDBManipulator.cs
@@ -1032,13 +1032,13 @@ public IEnumerator<TItem> FindByPrimaryKeyPrefix<TItem>(in ReadOnlySpan<byte> ke
     public TItem FirstByPrimaryKey<TItem>(int loaderIndex, ConstraintInfo[] constraints, ICollection<TItem> target,
         IOrderer[]? orderers, bool hasOrDefault) where TItem : class
     {
-        MemWriter keyBytes = new();
+        var keyBytes = MemWriter.CreateFromStackAllocatedSpan(stackalloc byte[4096]);
         keyBytes.WriteBlock(_relationInfo.Prefix);
 
         var relationVersionInfo = _relationInfo.ClientRelationVersionInfo;
         var primaryKeyFields = relationVersionInfo.PrimaryKeyFields.Span;
 
-        Span<byte> buffer = stackalloc byte[1024];
+        Span<byte> buffer = stackalloc byte[4096];
         var writer = MemWriter.CreateFromStackAllocatedSpan(buffer);
         if (orderers == null || orderers.Length == 0)
         {
@@ -1085,12 +1085,11 @@ public TItem FirstByPrimaryKey<TItem>(int loaderIndex, ConstraintInfo[] constrai
     public TItem FirstBySecondaryKey<TItem>(int loaderIndex, ConstraintInfo[] constraints, uint secondaryKeyIndex,
         IOrderer[]? orderers, bool hasOrDefault) where TItem : class
     {
-        var keyBytes = MemWriter.CreateFromStackAllocatedSpan(stackalloc byte[16]);
+        var keyBytes = MemWriter.CreateFromStackAllocatedSpan(stackalloc byte[4096]);
         keyBytes.WriteBlock(_relationInfo.PrefixSecondary);
         var remappedSecondaryKeyIndex = RemapPrimeSK(secondaryKeyIndex);
         keyBytes.WriteUInt8((byte)remappedSecondaryKeyIndex);
-        Span<byte> keyBuffer = stackalloc byte[4096];
-        var writer = MemWriter.CreateFromStackAllocatedSpan(keyBuffer);
+        var writer = MemWriter.CreateFromStackAllocatedSpan(stackalloc byte[4096]);
         if (orderers == null || orderers.Length == 0)
         {
             using var enumerator = new RelationConstraintSecondaryKeyEnumerator<TItem>(_transaction, _relationInfo,
@@ -1258,7 +1257,7 @@ public ulong GatherByPrimaryKey<TItem>(int loaderIndex, ConstraintInfo[] constra
             skip = 0;
         }
 
-        var writer = MemWriter.CreateFromStackAllocatedSpan(stackalloc byte[1024]);
+        var writer = MemWriter.CreateFromStackAllocatedSpan(stackalloc byte[4096]);
         var relationVersionInfo = _relationInfo.ClientRelationVersionInfo;
         var primaryKeyFields = relationVersionInfo.PrimaryKeyFields.Span;
 
@@ -1363,7 +1362,7 @@ public ulong GatherBySecondaryKey<TItem>(int loaderIndex, ConstraintInfo[] const
 
         var fastIteration = IsFastIterable(constraints, constraints.Length);
 
-        var writer = MemWriter.CreateFromStackAllocatedSpan(stackalloc byte[1024]);
+        var writer = MemWriter.CreateFromStackAllocatedSpan(stackalloc byte[4096]);
         if (orderers == null || orderers.Length == 0)
         {
             using var enumerator = new RelationConstraintSecondaryKeyEnumerator<TItem>(_transaction, _relationInfo,