Fix #133 -- Make sure initialization only happens once #134
Conversation
django_dramatiq/apps.py
Outdated
| def ready(self): | ||
| if getattr(self, "_is_ready", False): | ||
| return | ||
| super().ready() |
There was a problem hiding this comment.
Having this piece in place would mean that we will never call ready() method, as here initialize is setting _is_ready=True. This generally won't be correct behaviour, even if it may solve the issue with multiple ready() call.
Would you mind trying out #137 this solution to see if this changes things for you?
Best,
Rust
There was a problem hiding this comment.
#137 works perfectly for me! So please ignore this PR and go ahead with that one, which is much better :-)
django_dramatiq/admin.py
Outdated
| message_dict = instance.message._asdict() | ||
|
|
||
| # make sure we can still get a representation of the | ||
| # kwargs payload when a non json encoder is in use | ||
| kwargs_encoder = DjangoDramatiqConfig.select_encoder() | ||
| if not isinstance(kwargs_encoder, JSONEncoder): | ||
| for k,v in message_dict['kwargs'].items(): | ||
| message_dict['kwargs'][k] = f"<{v}>" | ||
|
|
||
| message_details = json.dumps(message_dict, indent=4) |
There was a problem hiding this comment.
That seems like a code that solves a different issue rather than #133. Was the second commit pushed by a mistake? It would be good to address different issues separately. 🙏
There was a problem hiding this comment.
yes you're right. I've made a mistake with the push to the main branch
This fixes the issue I encounter. The fix is pretty simple, using a global variable. GLobal variables are in use anyway, so it seemed legit to use it here as well