Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store traceback in django admin #142

Merged
merged 3 commits into from
Jul 4, 2023
Merged

Conversation

pickfire
Copy link
Contributor

Currently the traceback stored in django admin relies on RetriesMiddleware, if retries is set to 0 or it is disabled, traceback is not stored in django admin, AdminMiddleware should always set traceback without depending on RetriesMiddleware.

Currently the traceback stored in django admin relies on
RetriesMiddleware, if retries is set to 0 or it is disabled, traceback
is not stored in django admin, AdminMiddleware should always set
traceback without depending on RetriesMiddleware.
django_dramatiq/middleware.py Outdated Show resolved Hide resolved
@spumer
Copy link
Contributor

spumer commented Jul 4, 2023

@amureki can you review/approve?

Co-authored-by: @spumer <spumer@users.noreply.github.com>
@amureki amureki self-assigned this Jul 4, 2023
Copy link
Collaborator

@amureki amureki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!
And I am sorry it took me so long to check/review!

Best,
Rust

@amureki amureki merged commit 334e3cb into Bogdanp:master Jul 4, 2023
amureki added a commit that referenced this pull request Jul 4, 2023
@amureki
Copy link
Collaborator

amureki commented Jul 4, 2023

Released in 0.11.3:
https://pypi.org/project/django-dramatiq/0.11.3/

@pickfire pickfire deleted the traceback branch July 10, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants