Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colorpalette click event listener triggers on all section clicks #23

Closed
timelsass opened this issue Dec 5, 2018 · 1 comment · Fixed by #167
Closed

colorpalette click event listener triggers on all section clicks #23

timelsass opened this issue Dec 5, 2018 · 1 comment · Fixed by #167
Labels
bug General bug issues

Comments

@timelsass
Copy link
Member

The colorPalette.bind_help_section_visibility has an event listener registered triggering for every click on .accordion-section. This is causing some performance issues as every registered section has listeners registered here:
https://github.com/BoldGrid/boldgrid-theme-framework/blob/dev/src/assets/js/customizer/color-palette.js#L74

I believe this is for an admin notice/pointer - but I think the listener should only be added for the color palettes expanded state to help reduce some of the memory/cpu consumption which is causing slow performance.

@timelsass
Copy link
Member Author

as another thought on this - the idea it appears was to show help on the first time a user visits this section. Now that notices are/have been introduced in the customizer by core - it might be more fitting to just move this logic over into a dismissable notice. Since it is just help information - I'm not entirely sure this logic is even needed anymore as we already have a paragraph of text explaining how to use it, and external links out to our documentation that further explains how to use it with pictures. My feeling is that if the UI needs to be explained 3 different ways - then it's a bad UI. I don't think it's a bad UI - so it doesn't need to be explained 3 different ways.

@timelsass timelsass added this to Low priority in Bug Backlog Dec 5, 2018
@timelsass timelsass added this to the 2.1.1 milestone Dec 5, 2018
@timelsass timelsass added the bug General bug issues label Dec 5, 2018
@timelsass timelsass removed this from the 2.1.1 milestone May 15, 2019
@jamesros161 jamesros161 added this to To do in Crio Bug Fixes Mar 12, 2020
@jamesros161 jamesros161 moved this from To do to In progress in Crio Bug Fixes Mar 13, 2020
@jamesros161 jamesros161 moved this from In progress to Done in Crio Bug Fixes Mar 13, 2020
Bug Backlog automation moved this from Low priority to Closed Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug General bug issues
Projects
Bug Backlog
  
Closed
Development

Successfully merging a pull request may close this issue.

1 participant