Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed bind_help_section #167

Merged
merged 7 commits into from
Mar 20, 2020
Merged

removed bind_help_section #167

merged 7 commits into from
Mar 20, 2020

Conversation

jamesros161
Copy link
Contributor

This PR resolves #23 by removing the event listener since it is no longer used anyways.

@rramo012 rramo012 requested review from rramo012 and removed request for bwmarkle March 20, 2020 17:07
@rramo012
Copy link
Member

I believe this notice is still being used. See: Boldgrid_Framework_Customizer_Colors->help_pointers . I don't have a problem with deleting this notice. Make sure you cleanup all the code here tho.

That Includes:

  • Delete this class - Boldgrid_Framework_Pointer
  • The file inclusion in load_dependencies
  • Boldgrid_Framework_Customizer_Colors->help_pointers

Copy link
Member

@rramo012 rramo012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This notice still exists

@jamesros161
Copy link
Contributor Author

* load_dependencies

I removed the class, and it's inclusions

@rramo012
Copy link
Member

This line should be removed as well: https://github.com/BoldGrid/boldgrid-theme-framework/blob/crio-23/src/includes/class-boldgrid-framework.php#L171 -- fatal error otherwise

Copy link
Member

@rramo012 rramo012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need changes

@rramo012 rramo012 merged commit a10dc51 into master Mar 20, 2020
@rramo012 rramo012 deleted the crio-23 branch March 20, 2020 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

colorpalette click event listener triggers on all section clicks
2 participants