Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continued padding / margin fixes in Crio #347

Closed
nicolepaschen opened this issue Feb 26, 2021 · 13 comments · Fixed by #517
Closed

Continued padding / margin fixes in Crio #347

nicolepaschen opened this issue Feb 26, 2021 · 13 comments · Fixed by #517
Labels
Projects
Milestone

Comments

@nicolepaschen
Copy link
Member

nicolepaschen commented Feb 26, 2021

  • PPBP Section sliders have horizontal scrollbar but only with Crio

  • Check the alignment of Custom Page Header Sample Layouts

  • Sticky Header menu background doesn't touch the sides

@jamesros161 jamesros161 added bug General bug issues Crio labels May 21, 2021
@jamesros161 jamesros161 added this to the 2.8.1 milestone May 24, 2021
@nicolepaschen
Copy link
Member Author

There is padding on the row, column, AND container on mobile: image

This is slightly more padding on the sides than we want. I removed it from the container and it looks like this:
image

@bwmarkle bwmarkle added this to To do in 2.8.1 May 26, 2021
@jamesros161 jamesros161 removed this from To do in 2.8.1 Jun 30, 2021
@jamesros161 jamesros161 added this to To do in 2.9.3 Jun 30, 2021
@jamesros161 jamesros161 removed this from To do in 2.9.3 Jun 30, 2021
@jamesros161 jamesros161 added this to To do in 2.9.3 Jun 30, 2021
@jamesros161 jamesros161 modified the milestones: 2.8.1, 2.9.1 Jun 30, 2021
@nicolepaschen
Copy link
Member Author

I have the same layout on standard and sticky header but the Site Title jumps like 15px

sticky-headeer-vs-standard

@nicolepaschen
Copy link
Member Author

nicolepaschen commented Jul 23, 2021

Menu jumps too
menu-too

@nicolepaschen
Copy link
Member Author

Editor:
image

Front End:
image

@nicolepaschen
Copy link
Member Author

also see #357

@jamesros161 jamesros161 removed this from To do in 2.9.3 Sep 9, 2021
@jamesros161 jamesros161 added this to In progress in 2.9.5 Sep 21, 2021
@jamesros161 jamesros161 moved this from In progress to To Do in 2.9.5 Sep 21, 2021
@nicolepaschen
Copy link
Member Author

The margin at the top was zero-ed out so it would line up with the page content. It should only be added to the first widget title.

not-enough-margin
first-of-type-only

@jamesros161 jamesros161 moved this from To Do to In progress in 2.9.5 Oct 11, 2021
@jamesros161 jamesros161 mentioned this issue Oct 11, 2021
@jamesros161 jamesros161 linked a pull request Oct 11, 2021 that will close this issue
@jamesros161 jamesros161 moved this from In progress to Review in progress in 2.9.5 Oct 11, 2021
@nicolepaschen
Copy link
Member Author

nicolepaschen commented Oct 20, 2021

For horizontal lines - they are in nested row code but they shouldn't get the negative margin applied like other nested rows
hr-code
hr-display

This is a hr in a nested row. It looks correct:
image

@nicolepaschen
Copy link
Member Author

This is still happening along with the menu jump - the sticky header container is slightly bigger than the standard:

#347 (comment)

@nicolepaschen
Copy link
Member Author

PPBP Section sliders have horizontal scrollbar but only with Crio

  • Sections should be full width
  • Navigation buttons NOT set to overlay
  • see scrollbar

@nicolepaschen
Copy link
Member Author

Sticky Header menu background doesn't touch the sides

When using the Coherent Inspiration, the standard header is full width so the menu background row touches the sides. I cannot get a sticky header to match this design, bc the sticky header menu background is contained to the menu items. Please have it span the entire length so sticky and standard can match.

sticky-header-menu-background

@nicolepaschen
Copy link
Member Author

nicolepaschen commented Oct 22, 2021

Custom Page Header Sample Layout 3 - please remove the top 15px of padding on the row.

@nicolepaschen nicolepaschen moved this from Review in progress to In progress in 2.9.5 Oct 22, 2021
@nicolepaschen nicolepaschen moved this from In progress to To Do in 2.9.5 Oct 22, 2021
@nicolepaschen
Copy link
Member Author

nicolepaschen commented Oct 22, 2021

This is a content slider which is a nested row - something is messing up the margins making the content no longer exactly centered:

not-centered

@nicolepaschen
Copy link
Member Author

I started with the Callaway Inspiration. When I changed the header to the default side header layout, I have a scrollbar at the bottom of my screen on tablet and desktop.

@jamesros161 jamesros161 moved this from To Do to Review in progress in 2.9.5 Oct 27, 2021
@nicolepaschen nicolepaschen moved this from Review in progress to Reviewer approved in 2.9.5 Nov 3, 2021
@jamesros161 jamesros161 moved this from Reviewer approved to Done in 2.9.5 Nov 16, 2021
@jamesros161 jamesros161 modified the milestones: 2.9.1, Stable Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
2.9.5
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants