Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Explicit button height and nowrap makes buttons on mobile look bad #475

Closed
jessecowens opened this issue Aug 5, 2021 · 0 comments · Fixed by #521
Closed

[Bug] Explicit button height and nowrap makes buttons on mobile look bad #475

jessecowens opened this issue Aug 5, 2021 · 0 comments · Fixed by #521
Projects
Milestone

Comments

@jessecowens
Copy link
Member

Describe the bug
Buttons using the class .btn are set to white-space: nowrap; (boldgrid-theme-framework/assets/css/components.min.css) and have an explicit height (crio/css/buttons.css).

Ideally, we would set this to wrap, and use min-height instead of height.

To Reproduce
Steps to reproduce the behavior:

  1. Create a button with a long anchor text and view it on mobile.

Expected behavior
The entire link text should be visible, wrap, and the button background should expand to the size of the text.

Screenshots
Current:
image
Proposed with min-height and normal white-space:
image

@jessecowens jessecowens added this to the 2.9.1 milestone Aug 5, 2021
@jamesros161 jamesros161 added this to To Do in 2.9.5 via automation Sep 29, 2021
@jamesros161 jamesros161 moved this from To Do to Push to Next Project in 2.9.5 Sep 29, 2021
@jamesros161 jamesros161 moved this from Push to Next Project to To Do in 2.9.5 Sep 29, 2021
jamesros161 added a commit that referenced this issue Oct 11, 2021
@jamesros161 jamesros161 mentioned this issue Oct 11, 2021
@jamesros161 jamesros161 linked a pull request Oct 11, 2021 that will close this issue
@jamesros161 jamesros161 moved this from To Do to Review in progress in 2.9.5 Oct 11, 2021
jamesros161 added a commit that referenced this issue Oct 18, 2021
@nicolepaschen nicolepaschen moved this from Review in progress to Reviewer approved in 2.9.5 Oct 20, 2021
2.9.5 automation moved this from Reviewer approved to Done Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
2.9.5
  
Done
Development

Successfully merging a pull request may close this issue.

1 participant