Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Footer Layout Delete Buttons are disabled in same row as Attribution #478

Closed
jessecowens opened this issue Aug 6, 2021 · 4 comments · Fixed by #487
Closed

[Bug] Footer Layout Delete Buttons are disabled in same row as Attribution #478

jessecowens opened this issue Aug 6, 2021 · 4 comments · Fixed by #487
Projects

Comments

@jessecowens
Copy link
Member

Describe the bug
When Crio is active together with the BoldGrid Connect IMH plugin, all delete buttons for the footer are disabled, not just the Attribution.

To Reproduce
Steps to reproduce the behavior:

  1. Install an Inspiration with Crio
  2. Install and activate the BoldGrid Connect Plugin
  3. Navigate to Footer Layout controls, and note that menus and widget areas do not have delete buttons.

Screenshots
image

@jessecowens jessecowens added this to To do in 2.9.0 Aug 6, 2021
@jessecowens
Copy link
Member Author

@jamesros161 since this plugin is included in all IMH installs, I recommend prioritizing it with the upcoming release

@jamesros161 jamesros161 removed this from To do in 2.9.0 Aug 9, 2021
@nicolepaschen
Copy link
Member

This is happening to me on an install without the BG Connect Plugin - when I add a new row to the footer I do not see the trash icon. If I publish and close the Customizer and re-open, then I see the trash icon as expected.

@jessecowens jessecowens changed the title [Bug] Footer Layout Delete Buttons are disabled with BoldGrid Connect Plugin [Bug] Footer Layout Delete Buttons are disabled in same row as Attribution Aug 24, 2021
@jessecowens
Copy link
Member Author

@jamesros161 I was wrong about the correlation with BoldGrid Connect, it actually affects any elements that are in the same row as the attribution.

@nicolepaschen
Copy link
Member

nicolepaschen commented Aug 24, 2021

Mine wasn't even in the same row - just any time I add a new row there isn't a trash can icon

image

jamesros161 added a commit that referenced this issue Aug 24, 2021
@jamesros161 jamesros161 mentioned this issue Aug 24, 2021
jamesros161 added a commit that referenced this issue Aug 24, 2021
* Fixes #478

* update version numbers
@jamesros161 jamesros161 added this to Done in 2.9.3 Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
2.9.3
Done
Development

Successfully merging a pull request may close this issue.

2 participants