Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Make embedded videos more responsive #490

Closed
jessecowens opened this issue Apr 23, 2021 · 1 comment · Fixed by #495
Closed

[Feature] Make embedded videos more responsive #490

jessecowens opened this issue Apr 23, 2021 · 1 comment · Fixed by #495
Projects

Comments

@jessecowens
Copy link
Member

Is your feature request related to a problem? Please describe.
If a video is embedded (either via the Add Media button, shortcode, or using a PPB block) the height of the iframe remains constant regardless of screen width.
Peek 2021-04-23 12-19

Describe the solution you'd like
CSS similar to the following can be added to video element divs:

.bg-video {
  overflow: hidden;
  padding-top: 56.25%;
  position: relative;
}
.bg-video iframe {
  border: 0;
  height: 100%;
  left: 0;
  position: absolute;
  top: 0;
  width: 100%;
}

Peek 2021-04-23 12-21

@jessecowens
Copy link
Member Author

Could be duplicate of #68

@jamesros161 jamesros161 transferred this issue from BoldGrid/boldgrid-theme-framework May 24, 2021
@jamesros161 jamesros161 transferred this issue from BoldGrid/post-and-page-builder Sep 8, 2021
@jamesros161 jamesros161 added this to To do in 2.9.3 Sep 8, 2021
@jamesros161 jamesros161 moved this from To do to In progress in 2.9.3 Sep 9, 2021
@jamesros161 jamesros161 moved this from In progress to In Review in 2.9.3 Sep 13, 2021
jamesros161 added a commit that referenced this issue Sep 13, 2021
@jamesros161 jamesros161 mentioned this issue Sep 13, 2021
@jamesros161 jamesros161 linked a pull request Sep 13, 2021 that will close this issue
jamesros161 added a commit that referenced this issue Sep 13, 2021
@nicolepaschen nicolepaschen moved this from In Review to Done in 2.9.3 Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
2.9.3
Done
Development

Successfully merging a pull request may close this issue.

1 participant