Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Footer links inherit site content link hover effect #733

Closed
nicolepaschen opened this issue Sep 12, 2022 · 2 comments · Fixed by #747
Closed

Footer links inherit site content link hover effect #733

nicolepaschen opened this issue Sep 12, 2022 · 2 comments · Fixed by #747
Labels
bug General bug issues Niche Websites
Milestone
2.17.1

Comments

@nicolepaschen
Copy link
Member

When using the standard Customizer created footer you can set the link color but not the hover effect which leads to links that aren't visible on hover:
footer-hover-effect

When I have a custom footer with buttons, the buttons inherit the standard site hover effect instead of acting like buttons:
custom-footer-buttons
@nicolepaschen nicolepaschen added bug General bug issues Niche Websites labels Sep 12, 2022
@nicolepaschen
Copy link
Member Author

image

I think this is stopping buttons from acting like buttons

@nicolepaschen
Copy link
Member Author

sidebar-hover

Not sure what is controlling the hover effect for links in sidebar. Again I can set link color but not hover effect. Site Content is to only add underline not change color

@jamesros161 jamesros161 added this to the 2.17.1 milestone Sep 20, 2022
jamesros161 added a commit that referenced this issue Sep 30, 2022
@jamesros161
Resolves #733
dd1e5e5
@jamesros161 jamesros161 mentioned this issue Sep 30, 2022
Merged
@nicolepaschen nicolepaschen mentioned this issue Sep 30, 2022
Closed
jamesros161 added a commit that referenced this issue Oct 5, 2022
@jamesros161
Issues 738 & 733 (#740)
d026915 
* resolves #738

* Resolves #733

* update Buttons in yarn.lock

* generalize btn selectors

* update Buttons in yarn.lock
@jamesros161 jamesros161 mentioned this issue Oct 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug General bug issues Niche Websites
Projects
None yet
Milestone
2.17.1
Development

Successfully merging a pull request may close this issue.

Branch 2.17.1 BoldGrid/boldgrid-theme-framework
2 participants
@nicolepaschen @jamesros161