Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added container controls for WooCommerce pages #203

Merged
merged 2 commits into from
Jun 2, 2020
Merged

Conversation

jamesros161
Copy link
Contributor

This will resolve #30

@jamesros161 jamesros161 requested a review from rramo012 June 1, 2020 19:02
Copy link
Member

@rramo012 rramo012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with the exception of the Jenkins failure

FILE: ...work/includes/customizer/class-boldgrid-framework-customizer.php

FOUND 1 ERROR AFFECTING 1 LINE

510 | ERROR | [x] Each line in an array declaration must end in a
| | comma (WordPress.Arrays.ArrayDeclaration.NoComma)

@jamesros161 jamesros161 merged commit 118e3ed into master Jun 2, 2020
@jamesros161 jamesros161 deleted the issue-30 branch June 10, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pages need container control
2 participants