Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Featured images for posts on blog page should link to post. #142

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

jamesros161
Copy link
Contributor

@jamesros161 jamesros161 commented Sep 7, 2022

This addresses #399

Description

Featured images for posts on blog page should link to post. The solution decided for this feature is, rather than have a toggle for whether the featured images should be links or not, this behavior will be standard. This is understood / expected behavior which was not previously included. This feature will apply to featured images for posts on the Post List ( Blog ) Page, with a featured image position of Above Header, Below Header, and In Post Content. This will not apply to 'Header Background' position setting, as this would interfere with the post meta links that are overlaying on top of the background image.

This specific PR addresses the templating changes. Styling changes can be found in BGTFW/PR#732

Testing Procedure

NOTE: Testing procedures for this PR and BGTFW/PR#732 are the same.

  1. Install the test version of Crio attached to this PR.
    crio-2.17.0-pr.732.zip. Alternatively, you can use this one-click install link to install this test zip on Cloud Wordpress.
  2. Ensure that you have a 'Blog' page, with at least one blog post. If installing Crio on a clean install, this can easily be done by adding the starter content.
  3. Add a featured image to at least one blog post if it doesn't already have it.
  4. In the WordPress Customizer, navigate to Design → Blog → Blog Page → Post List Settings → Featured Images
  5. Test the Following positions: Above Header, Below Header, and In Post Content and ensure that each option links to the post.

@joe9663
Copy link
Contributor

joe9663 commented Sep 7, 2022

Acceptance testing completed

@jamesros161 jamesros161 merged commit 664e1ec into master Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants