Fix unmount error #209
Merged
Fix unmount error #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinBolt1987
approved these changes
Mar 1, 2024
| @@ -25,7 +25,7 @@ const { boltIgniteEnabled, isShopperLoggedIn: isBoltShopperLoggedIn } = window.B | |||
| } | |||
| await account.waitForBoltReady(); | |||
|
|
|||
| unmounts.forEach((unmount) => unmount && unmount()); | |||
| // unmounts.forEach((unmount) => unmount && unmount()); | |||
There was a problem hiding this comment.
Can you add a TODO here in case it's forgotten?
There was a problem hiding this comment.
It's fixes now so I'll revert
alanthai
force-pushed
the
athai/fix-unmount-error
branch
from
c7fc094
to
3a3668f
Compare
alanthai
force-pushed
the
athai/fix-unmount-error
branch
from
3a3668f
to
93b9f01
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
boltEmbed. The base one (notcheckout/embed) is also used in Loginunmount()causing errors. Will fix in next PR when the embed script is fixed.