Skip to content
This repository has been archived by the owner on Apr 29, 2024. It is now read-only.

Fix response fields used by CyberSource tokenization #261

Merged
merged 5 commits into from
Aug 25, 2023

Conversation

Wolfizen
Copy link
Contributor

Description

The documentation I followed here used an incorrect schema. The real responses observed do not match the documentation.

This PR updates the fields we use to match the real observed responses.

@Wolfizen
Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@Wolfizen
Copy link
Contributor Author

I'm completely unsure why CYBS TestVoid is failing.. it works when I run the integration test on my local machine against our sandbox account

@Wolfizen
Copy link
Contributor Author

Wolfizen commented Aug 25, 2023

  1. Add debug test
if cybersourceResponse != nil {
	b, _ := json.Marshal(cybersourceResponse)
	fmt.Printf("resp %s\n", b) // debug
}
  1. Build passes
  2. Remove debug test
  3. Build fails

🤯

@Wolfizen Wolfizen force-pushed the winona/fixCybersourceTokenizeResponseFields branch from 5b02264 to 0da37ea Compare August 25, 2023 09:24
@Wolfizen
Copy link
Contributor Author

Wolfizen commented Aug 25, 2023

Ok, so,, I added all the logging I could, and it seems that this may have just been a Cybersource sandbox service issue. Nothing looked different between the successes and failures.

I'm going to keep the logging because I put a bunch of work into making a way better logger and it can be re-used for other tests that want to log their http requests. (The logs aren't part of the non-test code)

@Wolfizen Wolfizen merged commit 4c384fe into master Aug 25, 2023
1 check passed
@Wolfizen Wolfizen deleted the winona/fixCybersourceTokenizeResponseFields branch August 25, 2023 20:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants