Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies update Nov 2024 #16

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Dependencies update Nov 2024 #16

merged 3 commits into from
Nov 13, 2024

Conversation

klinga
Copy link
Member

@klinga klinga commented Nov 11, 2024

Bumps the version of pymarc to 5.2.3, introducing the new Indicators class. While Indicators are supposedly backward compatible, comparisons to a list no longer work—a fairly common occurrence in tests.

Example:

Indicators("1", " 0") == ("1", "0")
True
Indicators("1", "0") == ["1", "0"]
False

FYI, the indicators constructor accepts Indicators, a tuple, and a list, the latter for backward compatibility.

Dependencies updates:

  • pymarc v5.2.3
  • pytest v8.3..3
  • black v24.8.0
  • mypy v1.13

Copy link
Contributor

@charlottekostelic charlottekostelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@klinga
Copy link
Member Author

klinga commented Nov 13, 2024

Thank you!

@klinga klinga merged commit 34e74cd into main Nov 13, 2024
8 checks passed
@klinga klinga deleted the depend-update-nov-2024 branch November 13, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants