Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split markdown #1307

Merged
merged 17 commits into from
Dec 20, 2017
Merged

Split markdown #1307

merged 17 commits into from
Dec 20, 2017
+257 −70

Conversation

sosukesuzuki
Copy link
Member

@sosukesuzuki sosukesuzuki commented Dec 18, 2017 •
edited
Loading

I implemented the new markdown editor.
It is split in half by markdown preview, and half by text editor.
12 -18-2017 19-01-06

@BoostnoteBot
Copy link
Collaborator

Please make sure to be pasted screenshots of all your changes.

@BoostnoteBot
Copy link
Collaborator

Be sure to be changed browser/main/Detail/SnippetNoteDetail.js.

@kazup01 kazup01 added the awaiting review ❇️ Pull request is awaiting a review. label Dec 18, 2017
@kazup01 kazup01 requested a review from Rokt33r December 18, 2017 13:27
Rokt33r
Rokt33r requested changes Dec 19, 2017
View reviewed changes
Copy link
Member

@Rokt33r Rokt33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mistakenly clicked approve button. I'll review it tonight.

@kazup01 kazup01 self-requested a review December 20, 2017 09:19
kazup01
kazup01 approved these changes Dec 20, 2017
View reviewed changes
Copy link
Member

@kazup01 kazup01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine

@kazup01 kazup01 merged commit 9007bac into master Dec 20, 2017
@kazup01
Copy link
Member

kazup01 commented Dec 20, 2017

Merged

@kazup01 kazup01 deleted the split-markdown branch December 20, 2017 09:20
@kazup01 kazup01 removed awaiting review ❇️ Pull request is awaiting a review. Next Release labels Dec 20, 2017
@kohei-takata kohei-takata mentioned this pull request Dec 23, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rokt33r Rokt33r Rokt33r requested changes

@kazup01 kazup01 kazup01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sosukesuzuki @BoostnoteBot @kazup01 @Rokt33r @ytk141