Fix configmanager #787
Merged
Fix configmanager #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmsuechan
commented
Aug 10, 2017
|
|
||
| config = Object.assign({}, DEFAULT_CONFIG, JSON.parse(config)) | ||
|
|
||
| config = Object.assign({}, DEFAULT_CONFIG, boostnotercConfig) |
There was a problem hiding this comment.
This line is the very reason why the bug happened.
|
Is this really desired behavior when the So, a user modifies something in the UI, everything works as he/she likes, then he/she restarts the app, and the settings is gone, replaced by the one from the Or is this |
Yes, it is. But I'll reconsider it. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context
It's a bug happens on v0.8.13.
before
The settings of Boostnote was reset and used DEFAULT_CONFIG unless
~/.boostnotercwas not created and set settings.after
Boostnote reads settings from localStorage and overwrites the settings when
~/.boostnotercexists.