Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Deprecation of direct use of pysha3 #416

Closed
YoshihitoAso opened this issue Nov 6, 2022 · 0 comments · Fixed by #417
Closed

[FEATURE] Deprecation of direct use of pysha3 #416

YoshihitoAso opened this issue Nov 6, 2022 · 0 comments · Fixed by #417
Assignees
@YoshihitoAso
Labels
enhancement New feature or request

Comments

@YoshihitoAso
Copy link
Member

YoshihitoAso commented Nov 6, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.

pysha3 is used for calculation of keccak256, but this 3rd-party library is not currently maintained.

Describe the solution you'd like

Use pycryptodome instead. In doing so, we indirectly use eth-utils ( > eth-hash > pycryptodome).
@YoshihitoAso YoshihitoAso added the enhancement New feature or request label Nov 6, 2022
@YoshihitoAso YoshihitoAso self-assigned this Nov 6, 2022
@YoshihitoAso YoshihitoAso mentioned this issue Nov 6, 2022
Merged
YoshihitoAso added a commit that referenced this issue Nov 7, 2022
@YoshihitoAso
Merge pull request #417 from BoostryJP/feature/#416
d3f1a02 
feat: Deprecation of direct use of pysha3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YoshihitoAso YoshihitoAso

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Deprecation of direct use of pysha3 BoostryJP/ibet-Prime
1 participant
@YoshihitoAso