Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error handling and validation for posted personal info length #730

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

purplesmoke05
Copy link
Member

  • Add error handling and validation for posted personal info length

@purplesmoke05 purplesmoke05 force-pushed the fix/error-handling-of-batch-pi-register branch from a1fe6bd to b37df46 Compare December 9, 2024 10:06
Copy link

github-actions bot commented Dec 9, 2024

Coverage

Coverage Report •
FileStmtsMissCoverMissing
config.py901286%45–46, 50, 73, 114, 339, 342, 347, 350, 352–354
app
   exceptions.py64198%163
app/routers/issuer
   bond.py117889623%227–228, 233–234, 237, 240, 245–247, 260–261, 264–265, 268, 284–290, 292, 294–301, 303, 306–307, 313–314, 317–324, 327–334, 337, 339, 342–350, 353–360, 364, 408–409, 411, 414–415, 418–421, 423, 451–454, 457–462, 464, 510–511, 530–533, 536–537, 543, 547–549, 553–555, 560–561, 568–569, 572–579, 582, 606–607, 611–612, 617–618, 621, 625–626, 629, 637–639, 641–642, 644, 647–650, 654, 702–705, 708, 715, 718–720, 722–723, 725, 728–731, 735–738, 749, 804–805, 824–827, 830–831, 836–837, 839, 870–871, 876–877, 879, 882–885, 889–892, 903, 912, 969–972, 975, 978–985, 987–993, 997, 1035–1036, 1058, 1069, 1114–1117, 1120, 1127, 1130–1132, 1134–1135, 1137, 1140–1143, 1147–1150, 1161, 1216–1217, 1236–1239, 1242–1243, 1248–1249, 1251, 1283–1284, 1289–1290, 1292, 1295–1298, 1302–1305, 1316, 1325, 1382–1385, 1388, 1391–1398, 1400–1406, 1410, 1448–1449, 1471, 1482, 1541–1543, 1546–1547, 1561, 1619–1622, 1625–1626, 1632, 1636–1638, 1642–1643, 1647, 1652–1661, 1664, 1722–1725, 1727–1728, 1730–1731, 1737, 1741–1743, 1747–1748, 1752, 1757–1766, 1768, 1772, 1819–1820, 1822, 1825–1826, 1890–1891, 1893, 1896–1897, 1908, 1911, 1937–1938, 1955–1958, 1961–1962, 2004–2005, 2015–2022, 2024, 2028–2030, 2033–2034, 2037–2038, 2042–2049, 2051, 2055–2057, 2061–2062, 2066–2067, 2072–2073, 2077–2078, 2084–2085, 2094–2101, 2103, 2105–2106, 2108–2109, 2111, 2114–2117, 2129, 2140–2141, 2148, 2153–2156, 2158, 2164, 2180, 2216–2217, 2234–2237, 2240, 2269, 2296–2297, 2314–2317, 2354–2360, 2362–2366, 2368–2371, 2373, 2380, 2402–2403, 2405, 2420–2421, 2423, 2425, 2437, 2492–2495, 2499–2507, 2511, 2571–2574, 2577, 2589–2595, 2599, 2603, 2605–2607, 2612, 2617–2618, 2620, 2652–2655, 2658, 2664–2665, 2670–2671, 2673, 2676–2679, 2685–2688, 2696, 2764–2769, 2771–2776, 2778–2779, 2781–2787, 2790, 2795, 2802–2803, 2805–2806, 2810, 2814, 2857–2858, 2872, 2972–2978, 2981, 2983–2986, 2989–2990, 2993–2994, 3001–3003, 3005, 3007, 3009, 3014–3017, 3019, 3036–3041, 3059, 3068, 3111–3112, 3131–3134, 3136–3137, 3142–3143, 3145, 3175–3178, 3181–3183, 3205–3206, 3210–3211, 3215–3220, 3225–3226, 3231–3244, 3248–3254, 3256–3257, 3259–3260, 3262, 3265–3268, 3274–3277, 3300, 3408–3411, 3415–3416, 3425, 3437, 3477–3480, 3483, 3536–3538, 3579–3584, 3589–3590, 3592–3594, 3596–3597, 3599, 3602–3605, 3618–3619, 3627–3632, 3634–3635, 3637–3640, 3642–3643, 3645, 3647, 3650, 3652, 3655, 3659–3660, 3663, 3665, 3667–3668, 3671, 3675, 3677–3678, 3681, 3685, 3687, 3696, 3705, 3729, 3785–3786, 3804–3807, 3822–3823, 3825–3829, 3833–3834, 3839, 3858–3859, 3874–3875, 3891–3892, 3901–3905, 3909–3910, 3915, 3919–3920, 3925–3928, 3930, 3932–3935, 3940, 3942–3944, 3946–3948, 3953, 3955–3959, 3962–3967, 3970, 3973, 4008–4011, 4026–4027, 4046–4047, 4052–4053, 4059–4062, 4068–4070, 4072–4077, 4079–4080, 4082–4085, 4087–4088, 4090, 4092, 4095, 4097, 4100, 4104–4105, 4108, 4110, 4112–4113, 4116, 4120, 4122–4123, 4126, 4130, 4136, 4141–4142, 4157, 4174, 4178, 4199, 4245–4247, 4249–4250, 4253, 4270–4273, 4278, 4281–4287, 4290–4300, 4304, 4351, 4354–4357, 4361–4364, 4375, 4467, 4470–4473, 4479–4480, 4485, 4510–4511, 4513
   share.py116487724%228–229, 234–236, 239, 242, 245, 256–257, 260–261, 264, 276–282, 284, 286–293, 295, 298–299, 305–306, 309–316, 319–326, 329, 331, 334–342, 345–352, 356, 394–395, 397–399, 402–405, 407, 435–438, 441–446, 448, 494–495, 514–517, 520–522, 527–528, 535–536, 539–546, 549, 573–574, 578–579, 584–585, 588, 592–593, 596, 604–606, 608–609, 611, 614–617, 621, 669–672, 675, 682, 685–687, 689–690, 692, 695–698, 702–705, 716, 771–772, 791–794, 797–798, 803–804, 806, 837–838, 843–844, 846, 849–852, 856–859, 870, 879, 936–939, 942, 945–952, 954–960, 964, 1002–1003, 1025, 1036, 1081–1084, 1087, 1094, 1097–1099, 1101–1102, 1104, 1107–1110, 1114–1117, 1128, 1183–1184, 1203–1206, 1209–1210, 1215–1216, 1218, 1250–1251, 1256–1257, 1259, 1262–1265, 1269–1272, 1283, 1292, 1349–1352, 1355, 1358–1365, 1367–1373, 1377, 1415–1416, 1438, 1449, 1508–1510, 1513–1514, 1528, 1586–1589, 1592–1594, 1599–1608, 1612, 1670–1673, 1675–1676, 1678–1680, 1685–1694, 1696, 1700, 1747–1748, 1750, 1753–1754, 1818–1819, 1821, 1824–1825, 1836, 1839, 1865–1866, 1883–1886, 1889–1890, 1932–1933, 1943–1950, 1952, 1956–1958, 1961–1962, 1965–1966, 1970–1977, 1979, 1983–1985, 1989–1990, 1994–1995, 2000–2001, 2005–2006, 2012–2013, 2022–2029, 2031, 2033–2034, 2036–2037, 2039, 2042–2045, 2057, 2068–2069, 2076, 2081–2084, 2086, 2092, 2108, 2144–2145, 2162–2165, 2168, 2197, 2224–2225, 2242–2245, 2282–2288, 2290–2294, 2296–2299, 2301, 2308, 2330–2331, 2333, 2348–2349, 2351, 2353, 2365, 2420–2423, 2427–2435, 2439, 2499–2502, 2505, 2517–2523, 2527, 2531, 2533–2535, 2540, 2545–2546, 2548, 2580–2583, 2586, 2592–2593, 2598–2599, 2601, 2604–2607, 2613–2616, 2624, 2692–2697, 2699–2704, 2706–2707, 2709–2715, 2718, 2722, 2729–2730, 2732–2733, 2737, 2741, 2786–2787, 2801, 2907–2909, 2911–2914, 2917, 2919–2922, 2925–2926, 2929–2930, 2937–2939, 2941, 2943, 2945, 2950–2953, 2955, 2972–2977, 2995, 3004, 3048–3049, 3068–3071, 3073–3074, 3079–3080, 3082, 3112–3115, 3118–3120, 3142–3143, 3147–3148, 3152–3157, 3162–3163, 3168–3181, 3185–3191, 3193–3194, 3196–3197, 3199, 3202–3205, 3211–3214, 3237, 3343–3346, 3350–3351, 3360, 3372, 3412–3415, 3418, 3471–3473, 3514–3519, 3524–3525, 3527–3529, 3531–3532, 3534, 3537–3540, 3553–3554, 3562–3567, 3569–3570, 3572–3575, 3577–3578, 3580, 3582, 3585, 3587, 3590, 3594–3595, 3598, 3600, 3602–3603, 3606, 3610, 3612–3613, 3616, 3620, 3622, 3631, 3640, 3664, 3720–3721, 3739–3742, 3757–3758, 3760–3764, 3768–3769, 3774, 3793–3794, 3809–3810, 3826–3827, 3836–3840, 3844–3845, 3850, 3854–3855, 3860–3863, 3865, 3867–3870, 3875, 3877–3879, 3881–3883, 3888, 3890–3894, 3897–3902, 3905, 3908, 3939–3942, 3957–3958, 3977–3978, 3983–3984, 3990–3993, 3999–4001, 4003–4008, 4010–4011, 4013–4016, 4018–4019, 4021, 4023, 4026, 4028, 4031, 4035–4036, 4039, 4041, 4043–4044, 4047, 4051, 4053–4054, 4057, 4061, 4067, 4072–4073, 4088, 4105, 4109, 4131, 4177–4179, 4181–4182, 4185, 4202–4205, 4210, 4213–4219, 4222–4232, 4236, 4283, 4286–4289, 4293–4296, 4307, 4399, 4402–4405, 4411–4412, 4417, 4442–4443, 4445
batch
   processor_batch_register_personal_info.py1733579%98, 145, 148, 166, 169, 257–258, 262, 440–442, 445–451, 455–458, 462, 464–465, 467, 471–473, 476–477, 481–484
tests/app
   test_bond_personal_info_InitiateBondTokenBatchPersonalInfoRegistration.py2590100% 
   test_bond_personal_info_RegisterBondTokenHolderPersonalInfo.py3760100% 
   test_share_personal_info_InitiateShareTokenBatchPersonalInfoRegistration.py2580100% 
   test_share_personal_info_RegisterShareTokenHolderPersonalInfo.py3760100% 
tests/batch
   test_processor_register_personal_info.py4130100% 
TOTAL78196415094% 

Tests Skipped Failures Errors Time
2026 0 💤 0 ❌ 0 🔥 16m 37s ⏱️

@purplesmoke05 purplesmoke05 marked this pull request as ready for review December 9, 2024 10:31
@YoshihitoAso YoshihitoAso merged commit 7d49420 into dev-24.12 Dec 10, 2024
@YoshihitoAso YoshihitoAso deleted the fix/error-handling-of-batch-pi-register branch December 10, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants