Fixed #38 #26
Closed
Fixed #38 #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defelo
requested changes
Oct 7, 2023
There was a problem hiding this comment.
I'm not sure if this is really the best solution for Bootstrap-Academy/Bootstrap-Academy#38. I think, the solution proposed in this ticket, to close one menu when opening another, makes more sense.
|
Preview deployed to https://71b69c26.academy-preview.pages.dev (total size: 11M) |
Defelo
added a commit
to JL-97/bootstrap-academy-frontend
that referenced
this pull request
Oct 12, 2023
|
Hi @FabulousCodingFox, are you still working on this? |
|
I am going to close this as i am not working on this anymore. I may or may not create a new pull in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The sidebar is now properly positioned over the profile menu
Type of change
Fixes Bootstrap-Academy/Bootstrap-Academy#38
My Bootstrap Academy username:
FabulousFox