-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Windows installers with jpackage #165
Conversation
@touwys, can you to try the new Windows installer(s)? |
Installed via the MSI to the default directory, The installation was problem-free, and the app also started without any apparent issues. |
I was a bit surprised by that as well, seems to be an individual installation rather then a shared installation.
Version is missing in application window title: Also the application is listed as "listfix" instead of "lisFix()". |
Version is missing in application window title:
Yes, I had already provided a screenshot of this incidence for another, recent distribution, which I am unable to track now. Should I, forthwith, peg down errors repeated in subsequent releases, everytime it is noticed? Is not once logged, sufficient?
____
Also the application is listed as "listfix" instead of "lisFix()".
Sorry, I missed this one, and cannot check the location of the error right now. Please note the spelling error at the end of the sentence above, in case you are copying and pasting it:
"lisFix()" should read "listFix()". The "t" is missing.
…----------------------------------------
23 Apr 2023 16:43:38 Borewit ***@***.***>:
@touwys[https://github.com/touwys], can you to try the new Windows installer(s)?
Installed via the MSI to the default directory, *C:\Users\*\AppData\Local*
I was a bit surprised by that as well, seems to be an individual installation rather then a shared installation. Need to check if I can customize that.
/The installation was problem-free, and the app also started without any apparent issues./
Version is missing in application window title:
[https://user-images.githubusercontent.com/23255260/233846325-740ce451-11d7-44de-a27d-3098e45838b6.png][image][https://user-images.githubusercontent.com/23255260/233846325-740ce451-11d7-44de-a27d-3098e45838b6.png][https://user-images.githubusercontent.com/23255260/233846325-740ce451-11d7-44de-a27d-3098e45838b6.png]
Also the application is listed as "listfix" instead of "lisFix()".
[https://user-images.githubusercontent.com/23255260/233846395-8bb9e54a-63ec-4c0c-ad40-75b9926639d4.png][image][https://user-images.githubusercontent.com/23255260/233846395-8bb9e54a-63ec-4c0c-ad40-75b9926639d4.png][https://user-images.githubusercontent.com/23255260/233846395-8bb9e54a-63ec-4c0c-ad40-75b9926639d4.png]
—
Reply to this email directly, view it on GitHub[#165 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/APVPQQVPDGP3UYPRDRRBBZLXCU5ZVANCNFSM6AAAAAAXH7KHWM].
You are receiving this because you were mentioned.[Tracking image][https://github.com/notifications/beacon/APVPQQXXCDTMZT2VV3NSYRTXCU5ZVA5CNFSM6AAAAAAXH7KHWOWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTS2RNQKW.gif]
|
In principal that is sufficient. I think this one is introduced in #164, which is kind of the groundwork for this PR, therefor I will address in this PR. I remember you have reported it before, but I think that was based on a screenshot I provided, running it in dev environment, but I could be wrong. Doesn't matter. |
"Save Playlist Error" I am logging this build-error here, instead "Issues": Unfortunately, I did not keep track of the steps that have led up to this error, but I did take the screenshot below. Does it help any? Playlist Saving Error _ Screenshot 20230425 ••••••• |
e3fb011
to
0460e4c
Compare
Can you try this this PR again @touwys?
|
Build: Windows |
listFix_2.7.0-11:
I could not reconstruct this error, confidently. Because, originally, it was induced purely by accident. Were you able to reconstruct the exact steps from the error report submitted?
No issues here. It lands on this page proper: Releases · Borewit/listFix
Below there are screenshots, some annotated, that graphically display some of the immediate results. I propose that the start-up splash screen gets modified to something similar to the one shown: • |
@Borewit : |
I reversed engineered the original splash screen to SVG which can be found here. One of the apps able to edit SVG is inkscape, or a text editor is enough to change a position. Note that the fourth digit group (.11) is the commit distance from the last release, that one will not be present the real release. |
No, but based on the error I think this is caused when the paylist is one drive, and at least one track on another drive. Then enable the relative path, and that is probably the way to reproduce it. |
I think the Playlist tab not introduced in this PR, so I guess best to create a new issue for that. |
What about any of the other GUI elements contained in the app — are there elements other than the splash-screen that may need an update/redesign from time-to-time? If here are, I would like to offer to help you with that, as far as I am able to. Also, is it imperative that all such images be presented in the SVG-format?
Yes, I am aware of that, but I submit that the centralised version number is more versatile and neater. |
SVG is the best foundation to store graphics. As it is commonly used, vector based (scale-able without loss of quality), it is code (text) (works well with repo and it allows to manipulate text). For some type of graphics is less suitable. I did some experiments with regenerating buttons, but I though the result of that was fairly disappointing. It looks like the Java Swing GUI as good in rendering graphics as browsers are nowadays. Buttons looked very pixelated. Maybe that gets better switching to JavaFx. |
.msi
&.exe
, with jpackage, and add these artifacts to the build pipelineRelated to #164