Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Windows installers with jpackage #165

Merged
merged 1 commit into from
May 2, 2023
Merged

Build Windows installers with jpackage #165

merged 1 commit into from
May 2, 2023

Conversation

Borewit
Copy link
Owner

@Borewit Borewit commented Apr 22, 2023

  1. Build .msi & .exe, with jpackage, and add these artifacts to the build pipeline
  2. Remove the previous jlink runtime image artifact from the pipeline
  3. Disabled the (DOS) console, (uses javaw instead of java)

Related to #164

indows installers

@Borewit Borewit added the DevOps label Apr 22, 2023
@Borewit Borewit self-assigned this Apr 22, 2023
@Borewit Borewit changed the title Build msi * exe with jpackage Build Windows installers with jpackage Apr 22, 2023
@Borewit
Copy link
Owner Author

Borewit commented Apr 22, 2023

@touwys, can you to try the new Windows installer(s)?

@touwys
Copy link

touwys commented Apr 23, 2023

@touwys, can you to try the new Windows installer(s)?

Installed via the MSI to the default directory, C:\Users\*\AppData\Local

The installation was problem-free, and the app also started without any apparent issues.

@Borewit
Copy link
Owner Author

Borewit commented Apr 23, 2023

@touwys, can you to try the new Windows installer(s)?

Installed via the MSI to the default directory, C:\Users\*\AppData\Local

I was a bit surprised by that as well, seems to be an individual installation rather then a shared installation.
Need to check if I can customize that.

The installation was problem-free, and the app also started without any apparent issues.

Version is missing in application window title:

image

Also the application is listed as "listfix" instead of "lisFix()".

image

@touwys
Copy link

touwys commented Apr 23, 2023 via email

@Borewit
Copy link
Owner Author

Borewit commented Apr 23, 2023

Is not once logged, sufficient?

In principal that is sufficient. I think this one is introduced in #164, which is kind of the groundwork for this PR, therefor I will address in this PR. I remember you have reported it before, but I think that was based on a screenshot I provided, running it in dev environment, but I could be wrong. Doesn't matter.

@touwys
Copy link

touwys commented Apr 25, 2023

@Borewit

"Save Playlist Error"

I am logging this build-error here, instead "Issues":

Unfortunately, I did not keep track of the steps that have led up to this error, but I did take the screenshot below. Does it help any?

Playlist Saving Error _ Screenshot 20230425

•••••••

@Borewit
Copy link
Owner Author

Borewit commented Apr 29, 2023

Can you try this this PR again @touwys?

  • I think I resolved the "Save Playlist Error" via Fix uncommon root path exception #170, which now included here as well.
  • Name corrected
  • windows update GUI added, which correlate updates (best to de-install previous version)
  • Fixed version number

@Borewit
Copy link
Owner Author

Borewit commented Apr 30, 2023

Build: Windows

@touwys
Copy link

touwys commented May 1, 2023

listFix_2.7.0-11:

I think I resolved the "Save Playlist Error" via Fix uncommon root exception #170, which now included here as well. ❔

I could not reconstruct this error, confidently. Because, originally, it was induced purely by accident. Were you able to reconstruct the exact steps from the error report submitted?

Name corrected. ✔️

windows update GUI added, which correlate updates (best to de-install previous version) ✔️

No issues here. It lands on this page proper: Releases · Borewit/listFix

Fixed version number ✔️


Below there are screenshots, some annotated, that graphically display some of the immediate results. I propose that the start-up splash screen gets modified to something similar to the one shown:


Default install directory:
20230501_installs to appdata local

Current splash screen:
20230501_splash screen at startup

Proposed splash screen:
20230501_splash screen at startup_revised

Playlist tab not refreshing, invariably.
20230501_playlist tab not refreshing one playlist changes are discarded

@touwys
Copy link

touwys commented May 2, 2023

@Borewit :
In the case of listFix(), how are the graphical elements incorporated into the software? Are these elements — for example the start-up splash screen — designed in another programme, ready to be imported for assimilation in the listFix() development package?

@Borewit
Copy link
Owner Author

Borewit commented May 2, 2023

@Borewit : In the case of listFix(), how are the graphical elements incorporated into the software? Are these elements — for example the start-up splash screen — designed in another programme, ready to be imported for assimilation in the listFix() development package?

I reversed engineered the original splash screen to SVG which can be found here.

One of the apps able to edit SVG is inkscape, or a text editor is enough to change a position.

Note that the fourth digit group (.11) is the commit distance from the last release, that one will not be present the real release.

@Borewit
Copy link
Owner Author

Borewit commented May 2, 2023

I could not reconstruct this error, confidently. Because, originally, it was induced purely by accident. Were you able to reconstruct the exact steps from the error report submitted?

No, but based on the error I think this is caused when the paylist is one drive, and at least one track on another drive. Then enable the relative path, and that is probably the way to reproduce it.

@Borewit
Copy link
Owner Author

Borewit commented May 2, 2023

Playlist tab not refreshing, invariably.

I think the Playlist tab not introduced in this PR, so I guess best to create a new issue for that.

@Borewit Borewit merged commit a61d30f into main May 2, 2023
@Borewit Borewit deleted the jpackage branch May 2, 2023 18:36
@touwys
Copy link

touwys commented May 3, 2023

I reversed engineered the original splash screen to SVG which can be found here.

What about any of the other GUI elements contained in the app — are there elements other than the splash-screen that may need an update/redesign from time-to-time? If here are, I would like to offer to help you with that, as far as I am able to. Also, is it imperative that all such images be presented in the SVG-format?

Note that the fourth digit group (.11) is the commit distance from the last release, that one will not be present the real release.

Yes, I am aware of that, but I submit that the centralised version number is more versatile and neater.

@Borewit
Copy link
Owner Author

Borewit commented May 4, 2023

Also, is it imperative that all such images be presented in the SVG-format?

SVG is the best foundation to store graphics. As it is commonly used, vector based (scale-able without loss of quality), it is code (text) (works well with repo and it allows to manipulate text). For some type of graphics is less suitable.

I did some experiments with regenerating buttons, but I though the result of that was fairly disappointing. It looks like the Java Swing GUI as good in rendering graphics as browsers are nowadays. Buttons looked very pixelated. Maybe that gets better switching to JavaFx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants