Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run CI on PRs (and on pushes to master) #2104

Closed
2 tasks done
bjornstar opened this issue Jun 30, 2024 · 0 comments · Fixed by #2105
Closed
2 tasks done

Run CI on PRs (and on pushes to master) #2104

bjornstar opened this issue Jun 30, 2024 · 0 comments · Fixed by #2105
Labels
bug Bug, will addressed with high priority

Comments

@bjornstar
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

music-metadata version

No response

JavaScript module eco system

None

Current Behavior

Opening a PR does not trigger CI to run against the code in the PR.

Expected Behavior

Opening a PR triggers CI to run against the code in the PR so we know if the changes will break the build.

Attached audio sample?

  • I have provided sufficient information to reproduce the issue
@bjornstar bjornstar added the bug Bug, will addressed with high priority label Jun 30, 2024
@bjornstar bjornstar mentioned this issue Jun 30, 2024
Merged
Borewit added a commit that referenced this issue Jun 30, 2024
@bjornstar @Borewit
Run CI on pushes and PRs to master (#2105)
917d835 
* run CI on pushes and pull requests to master (fixes #2104)
* use up-to-date versions of github actions
* update node.js CI badge to reflect status on master
* ignore engines with yarn install on appveyor since it's still on node 16
* remove extraneous whitespace
* CI: Update Node.js version used in build to v22

Updates syntax in unit tests to comply with updates TypeScript

---------

Co-authored-by: Borewit <Borewit@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Bug, will addressed with high priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run CI on pushes and PRs to master
1 participant
@bjornstar