Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ID3v2.3 & ID3v2.4 USLT mapping to common.lyrics #2050

Merged
merged 1 commit into from
May 28, 2024

Conversation

Borewit
Copy link
Owner

@Borewit Borewit commented May 21, 2024

Related to #1974, fixes id3v2.4 USLT mapping to common.lyrics

References:

@Borewit Borewit added the bug Bug, will addressed with high priority label May 21, 2024
@Borewit Borewit self-assigned this May 21, 2024
@Borewit Borewit force-pushed the fix-id3v2.uslt-mapping branch from 7a6e505 to 7bfa49b Compare May 21, 2024 20:05
@coveralls
Copy link

Coverage Status

coverage: 96.524% (-0.007%) from 96.531%
when pulling 7bfa49b on fix-id3v2.uslt-mapping
into ca98704 on master.

@ffxsam
Copy link

ffxsam commented May 28, 2024

@Borewit Thanks a ton! Will keep an eye out for when this is published to npm.

@Borewit
Copy link
Owner Author

Borewit commented May 28, 2024

@Borewit Thanks a ton! Will keep an eye out for when this is published to npm.

Sorry, busy, forgot about it

@Borewit Borewit merged commit bb54843 into master May 28, 2024
19 checks passed
@Borewit Borewit deleted the fix-id3v2.uslt-mapping branch May 28, 2024 20:41
@Borewit
Copy link
Owner Author

Borewit commented May 29, 2024

Part of v8.3.0

@ffxsam
Copy link

ffxsam commented May 29, 2024

@Borewit You rock! Thanks for fixing both lyrics & grouping! Sending an extra donation your way shortly. 🙏

Quick question: I noticed common.lyrics is an array. Any reason this is the case? From what I can tell, even if there are multiple lines, it's just a single string separated by newlines. Unless there's some way to add multiple versions of lyrics or something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug, will addressed with high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants