Skip to content

Commit

Permalink
Do not hard set config in CPTC files (qmk#11864)
Browse files Browse the repository at this point in the history
  • Loading branch information
drashna authored May 23, 2021
1 parent a9779e1 commit 9b61ffb
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
6 changes: 5 additions & 1 deletion common_features.mk
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,11 @@ endif
VALID_BACKLIGHT_TYPES := pwm timer software custom

BACKLIGHT_ENABLE ?= no
BACKLIGHT_DRIVER ?= pwm
ifeq ($(strip $(CONVERT_TO_PROTON_C)), yes)
BACKLIGHT_DRIVER ?= software
else
BACKLIGHT_DRIVER ?= pwm
endif
ifeq ($(strip $(BACKLIGHT_ENABLE)), yes)
ifeq ($(filter $(BACKLIGHT_DRIVER),$(VALID_BACKLIGHT_TYPES)),)
$(error BACKLIGHT_DRIVER="$(BACKLIGHT_DRIVER)" is not a valid backlight type)
Expand Down
7 changes: 2 additions & 5 deletions platforms/chibios/QMK_PROTON_C/convert_to_proton_c.mk
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,5 @@ BOARD := QMK_PROTON_C
OPT_DEFS += -DCONVERT_TO_PROTON_C

# These are defaults based on what has been implemented for ARM boards
AUDIO_ENABLE = yes
WS2812_DRIVER = bitbang

# Force task driven PWM until ARM can provide automatic configuration
BACKLIGHT_DRIVER = software
AUDIO_ENABLE ?= yes
WS2812_DRIVER ?= bitbang

0 comments on commit 9b61ffb

Please sign in to comment.