Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: serde-serialize can trigger package cycle detection #967

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

nicarq
Copy link
Contributor

@nicarq nicarq commented Sep 18, 2024

I'm getting this error when loading the Rust project from an external source that uses wasm

package:   /Users/nijaar/shinkai/develop/shinkai-node/shinkai-libs/shinkai-baml/Cargo.toml
workspace: /Users/nijaar/shinkai/develop/shinkai-node/Cargo.toml
    Updating crates.io index
    Updating git repository https://github.com/BoundaryML/baml.git
error: cyclic package dependency: package getrandom v0.2.15 depends on itself. Cycle:
package getrandom v0.2.15
    ... which satisfies dependency getrandom = "^0.2.0" of package const-random-macro v0.1.16
    ... which satisfies dependency const-random-macro = "^0.1.16" of package const-random v0.1.18
    ... which satisfies dependency const-random = "^0.1.17" of package ahash v0.8.11
    ... which satisfies dependency ahash = "^0.8.7" of package hashbrown v0.14.5
    ... which satisfies dependency hashbrown = "^0.14.1" of package indexmap v2.5.0
    ... which satisfies dependency indexmap = "^2.2.3" of package serde_json v1.0.128
    ... which satisfies dependency serde_json = "^1.0" of package wasm-bindgen v0.2.93
    ... which satisfies dependency wasm-bindgen = "^0.2.93" of package js-sys v0.3.70
    ... which satisfies dependency js-sys = "^0.3" of package getrandom v0.2.15
    ... which satisfies dependency getrandom = "^0.2" of package rand_core v0.6.4
    ... which satisfies dependency rand_core = "^0.6" of package crypto-common v0.1.6
    ... which satisfies dependency crypto-common = "^0.1.4" of package aead v0.5.2

I created another Rust project that uses baml and it wasn't hitting the issue, so it seems that for some reason projects that also use wasm trigger the issue.

it seems to be a very common issue

tkaitchuck/aHash#95
rustwasm/gloo#239

image

the tldr is that the feature serde-serializer seems to be the culprit (deprecated). it's recommended to move to use serde_wasm_bindgen which baml already uses! so the fix seems to be just removing the feature.

From my limited experience of the project and to try to make sure that the wasm build still compiles and works, i actually compiled it myself and tested it in a nodejs project, and it continues to work.

Then I imported this branch to the other project and it worked without hitting the dependency cycle issue.

Copy link

vercel bot commented Sep 18, 2024

@nicarq is attempting to deploy a commit to the Gloo Team on Vercel.

A member of the Team first needs to authorize it.

@sxlijin sxlijin changed the title Rust build (from external project) hitting package cycle detection fix: serde-serialize triggers package cycle detection Sep 18, 2024
@sxlijin sxlijin changed the title fix: serde-serialize triggers package cycle detection fix: serde-serialize can trigger package cycle detection Sep 18, 2024
@nicarq nicarq force-pushed the nico/maybe_fix_cycle branch from 7465b89 to 89a8055 Compare September 18, 2024 23:18
@sxlijin sxlijin merged commit 109ae09 into BoundaryML:canary Sep 18, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants