Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert changes made to BOM creation in #480 #482

Merged
merged 1 commit into from
Jun 19, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions fabrication.py
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,7 @@ def generate_cpl(self):
)
self.logger.info("Finished generating CPL file %s", os.path.join(self.outputdir, cplname))


def generate_bom(self):
"""Generate BOM file."""
bomname = f"BOM-{Path(self.filename).stem}.csv"
Expand All @@ -289,12 +290,7 @@ def generate_bom(self):
) as csvfile:
writer = csv.writer(csvfile, delimiter=",")
writer.writerow(["Comment", "Designator", "Footprint", "LCSC"])
footprints = sorted(self.board.Footprints(), key = lambda x: x.GetReference())
for fp in footprints:
# for part in self.parent.store.read_bom_parts():
part = self.parent.store.get_part(fp.GetReference())
if part[5] == 1: # Exclude from BOM
continue
for part in self.parent.store.read_bom_parts():
if not add_without_lcsc and not part[3]:
continue
writer.writerow(part)
Expand Down