Revert RHS Change to ammo_Penetrator_Base #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RHS adds config edits to create 30 submunitions to emulate spalling to the
ammo_Penetrator_Base* base class that all vanilla and most modded penetrators are inherit from. This is a pretty cool effect and can be deadly, but also doesn't account for how some mods use penetrators. For example, CUP's 105mm M393A3 HEP round creates 8 penetrators, each which combined with RHS produce 30 spall submunitions.This PR
ammo_Penetrator_Baseclass.If we want to still create these submunitions on non-RHS penetrators, that's fine. I can just tweak how some of the rounds create penetrators to account for it. Feedback welcome.
See discord for videos. I usually enjoy this feature as we don't use any other form of spalling, but it looks like it causes some unintended issues.
* Penetrators are spawned by HEAT and some AP rounds to emulate the penetration and damage to components the projectile does. This allows projectiles to have the capability to do more damage inside an armor, while also detonating outside a vehicle.