adjusted tests, remove module from base if extracted

BowlingX · Jun 17, 2017 · 09ac8cb · 09ac8cb
1 parent 1791796
commit 09ac8cb
Show file tree

Hide file tree

Showing 5 changed files with 24 additions and 4 deletions.
diff --git a/index.js b/index.js
@@ -274,6 +274,10 @@ ExtractTextPlugin.prototype.apply = function(compiler) {
 					if(meta && (!meta.options.id || meta.options.id === id)) {
 						var wasExtracted = Array.isArray(meta.content);
 						if(shouldExtract !== wasExtracted) {
+							if (shouldExtract) {
+								chunk.removeModule(module);
+								return callback();
+							}
 							module[NS + "/extract"] = shouldExtract; // eslint-disable-line no-path-concat
 							compilation.rebuildModule(module, function(err) {
 								if(err) {

diff --git a/test/cases/multiple-entries-async/expected/0.js b/test/cases/multiple-entries-async/expected/0.js
@@ -3,12 +3,16 @@ webpackJsonp([0],{
 /***/ 2:
 /***/ (function(module, exports, __webpack_require__) {
 
-__webpack_require__(7);
+__webpack_require__(9);
+
+modules.export = function() {
+	return 'Route Homepage';
+};
 
 
 /***/ }),
 
-/***/ 7:
+/***/ 9:
 /***/ (function(module, exports) {
 
 module.exports = "styles-homepage\n"

diff --git a/test/cases/multiple-entries-async/expected/1.js b/test/cases/multiple-entries-async/expected/1.js
@@ -3,12 +3,16 @@ webpackJsonp([1],{
 /***/ 1:
 /***/ (function(module, exports, __webpack_require__) {
 
-__webpack_require__(6);
+__webpack_require__(8);
+
+modules.export = function() {
+	return 'Route Contact';
+};
 
 
 /***/ }),
 
-/***/ 6:
+/***/ 8:
 /***/ (function(module, exports) {
 
 module.exports = "styles-contact\n"

diff --git a/test/cases/multiple-entries-async/routes/contact/index.js b/test/cases/multiple-entries-async/routes/contact/index.js
@@ -1 +1,5 @@
 require('./styles.txt');
+
+modules.export = function() {
+	return 'Route Contact';
+};
diff --git a/test/cases/multiple-entries-async/routes/homepage/index.js b/test/cases/multiple-entries-async/routes/homepage/index.js
@@ -1 +1,5 @@
 require('./styles.txt');
+
+modules.export = function() {
+	return 'Route Homepage';
+};