-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Predefined functions enhancements #130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified against the WP functions: ✅
Docs: ❌ - I'd expect these need to be added to the "Generic functions" list in the wordpress-tools.md
file.
Tests: ❌ - I don't see any (availability) tests for this functionality.
Relates to #125
I created a PR #134 into this branch which adds some test assertions for If this is the right approach, and that PR gets merged, then I could similarly add some test assertions for @gmazzap or @jrfnl, if you get a chance to take a look at #134, please let me know if that can be merged, or if you'd recommend any different approach for adding these tests. |
…test-assertions Add wp_validate_boolean test assertions
Codecov ReportPatch coverage has no change and project coverage change:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #130 +/- ##
============================================
- Coverage 92.25% 91.90% -0.35%
Complexity 312 312
============================================
Files 28 28
Lines 710 828 +118
============================================
+ Hits 655 761 +106
- Misses 55 67 +12 see 20 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Thanks @jrfnl for the review and sanity check, as usual. Thanks @paulshryock for the PR, approved your PR and merged it. I added docs and test for |
Add stubs for
wp_validate_boolean()
andwp_slash()
.See #125