cleaned up python code #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lloydoad
reviewed
Nov 23, 2020
Comment on lines
+12
to
+18
| exit() | ||
|
|
||
| confirmConnection() | ||
| data = recordEEG(stream_connection) | ||
| if data == None: | ||
| debugPrint("Could not record data from EEG headset... exiting.....") | ||
| exit() |
There was a problem hiding this comment.
I'm assuming these were tested?
There was a problem hiding this comment.
Also using raise RuntimeError('Some error message') to send an exception to standard error may be the better option.
There was a problem hiding this comment.
That does sound like a better option, ill change it
| debugPrint("Loading model....") | ||
| model_path = f"{Path.cwd()}/model.h5" | ||
| model_path = f"{Path.cwd()}/checkpoints/model.h5" | ||
| cpu = False |
There was a problem hiding this comment.
Isn't this always going to attempt to use GPU then? Whats the point of having the flag
There was a problem hiding this comment.
Whoops I meant to change that, thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.