Ask libtool to stop hiding some errors

For openzfs#13083, curiously, it did not print the actual error, just that the compile failed with "Error 1". In theory, this flag should cause it to report errors twice sometimes. In practice, I'm pretty okay with reporting some twice if it avoids reporting some never. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com> Signed-off-by: Rich Ercolani <rincebrain@gmail.com> Closes openzfs#13086
BrainSlayer · Apr 11, 2022 · 58b1c44 · 58b1c44
1 parent 5a3f2fd
commit 58b1c44
Show file tree

Hide file tree

Showing 15 changed files with 36 additions and 0 deletions.
diff --git a/lib/libavl/Makefile.am b/lib/libavl/Makefile.am
@@ -5,6 +5,8 @@ VPATH = $(top_srcdir)/module/avl/
 # Includes kernel code, generate warnings for large stack frames
 AM_CFLAGS += $(FRAME_LARGER_THAN)
 AM_CFLAGS += -fvisibility=hidden
+# See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54020
+AM_CFLAGS += -no-suppress
 
 noinst_LTLIBRARIES = libavl.la
 

diff --git a/lib/libefi/Makefile.am b/lib/libefi/Makefile.am
@@ -2,6 +2,8 @@ include $(top_srcdir)/config/Rules.am
 
 AM_CFLAGS += $(LIBUUID_CFLAGS) $(ZLIB_CFLAGS)
 AM_CFLAGS += -fvisibility=hidden
+# See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54020
+AM_CFLAGS += -no-suppress
 
 noinst_LTLIBRARIES = libefi.la
 

diff --git a/lib/libicp/Makefile.am b/lib/libicp/Makefile.am
@@ -6,6 +6,8 @@ VPATH = \
 
 # Includes kernel code, generate warnings for large stack frames
 AM_CFLAGS += $(FRAME_LARGER_THAN)
+# See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54020
+AM_CFLAGS += -no-suppress
 
 noinst_LTLIBRARIES = libicp.la
 

diff --git a/lib/libnvpair/Makefile.am b/lib/libnvpair/Makefile.am
@@ -8,6 +8,8 @@ VPATH = \
 # and required CFLAGS for libtirpc
 AM_CFLAGS += $(FRAME_LARGER_THAN) $(LIBTIRPC_CFLAGS)
 AM_CFLAGS += -fvisibility=hidden
+# See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54020
+AM_CFLAGS += -no-suppress
 
 # wchar_t is undefined-signedness, but we compare to >=0; this warns with unsigned wchar_t
 libnvpair_json.$(OBJEXT): CFLAGS += -Wno-type-limits

diff --git a/lib/libshare/Makefile.am b/lib/libshare/Makefile.am
@@ -3,6 +3,8 @@ include $(top_srcdir)/config/Rules.am
 DEFAULT_INCLUDES += -I$(srcdir)
 
 AM_CFLAGS += -fvisibility=hidden
+# See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54020
+AM_CFLAGS += -no-suppress
 
 noinst_LTLIBRARIES = libshare.la
 

diff --git a/lib/libspl/Makefile.am b/lib/libspl/Makefile.am
@@ -2,6 +2,9 @@ include $(top_srcdir)/config/Rules.am
 
 SUBDIRS = include
 
+# See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54020
+AM_CFLAGS += -no-suppress
+
 noinst_LTLIBRARIES = libspl_assert.la libspl.la
 
 libspl_assert_la_SOURCES = \

diff --git a/lib/libtpool/Makefile.am b/lib/libtpool/Makefile.am
@@ -1,9 +1,13 @@
 include $(top_srcdir)/config/Rules.am
 
 AM_CFLAGS += -fvisibility=hidden
+
 # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61118
 AM_CFLAGS += $(NO_CLOBBERED)
 
+# See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54020
+AM_CFLAGS += -no-suppress
+
 noinst_LTLIBRARIES = libtpool.la
 
 USER_C = \

diff --git a/lib/libunicode/Makefile.am b/lib/libunicode/Makefile.am
@@ -5,6 +5,9 @@ VPATH = $(top_srcdir)/module/unicode
 # Includes kernel code, generate warnings for large stack frames
 AM_CFLAGS += $(FRAME_LARGER_THAN)
 
+# See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54020
+AM_CFLAGS += -no-suppress
+
 noinst_LTLIBRARIES = libunicode.la
 
 KERNEL_C = \

diff --git a/lib/libuutil/Makefile.am b/lib/libuutil/Makefile.am
@@ -1,5 +1,8 @@
 include $(top_srcdir)/config/Rules.am
 
+# See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54020
+AM_CFLAGS += -no-suppress
+
 lib_LTLIBRARIES = libuutil.la
 
 include $(top_srcdir)/config/Abigail.am

diff --git a/lib/libzfs/Makefile.am b/lib/libzfs/Makefile.am
@@ -8,6 +8,8 @@ VPATH = \
 # Suppress unused but set variable warnings often due to ASSERTs
 AM_CFLAGS += $(LIBCRYPTO_CFLAGS) $(ZLIB_CFLAGS)
 AM_CFLAGS += -fvisibility=hidden
+# See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54020
+AM_CFLAGS += -no-suppress
 
 pkgconfig_DATA = libzfs.pc
 

diff --git a/lib/libzfs_core/Makefile.am b/lib/libzfs_core/Makefile.am
@@ -3,6 +3,8 @@ include $(top_srcdir)/config/Rules.am
 pkgconfig_DATA = libzfs_core.pc
 
 AM_CFLAGS += -fvisibility=hidden
+# See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54020
+AM_CFLAGS += -no-suppress
 
 lib_LTLIBRARIES = libzfs_core.la
 

diff --git a/lib/libzfsbootenv/Makefile.am b/lib/libzfsbootenv/Makefile.am
@@ -3,6 +3,8 @@ include $(top_srcdir)/config/Rules.am
 pkgconfig_DATA = libzfsbootenv.pc
 
 AM_CFLAGS += -fvisibility=hidden
+# See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54020
+AM_CFLAGS += -no-suppress
 
 lib_LTLIBRARIES = libzfsbootenv.la
 

diff --git a/lib/libzpool/Makefile.am b/lib/libzpool/Makefile.am
@@ -24,6 +24,9 @@ AM_CFLAGS += $(ZLIB_CFLAGS)
 
 AM_CFLAGS += -DLIB_ZPOOL_BUILD
 
+# See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54020
+AM_CFLAGS += -no-suppress
+
 lib_LTLIBRARIES = libzpool.la
 
 USER_C = \

diff --git a/lib/libzstd/Makefile.am b/lib/libzstd/Makefile.am
@@ -5,6 +5,8 @@ VPATH = $(top_srcdir)/module/zstd
 # -fno-tree-vectorize is set for gcc in zstd/common/compiler.h
 # Set it for other compilers, too.
 AM_CFLAGS += -fno-tree-vectorize
+# See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54020
+AM_CFLAGS += -no-suppress
 
 noinst_LTLIBRARIES = libzstd.la
 

diff --git a/lib/libzutil/Makefile.am b/lib/libzutil/Makefile.am
@@ -2,6 +2,8 @@ include $(top_srcdir)/config/Rules.am
 
 AM_CFLAGS += $(LIBBLKID_CFLAGS) $(LIBUDEV_CFLAGS)
 AM_CFLAGS += -fvisibility=hidden
+# See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54020
+AM_CFLAGS += -no-suppress
 
 DEFAULT_INCLUDES += -I$(srcdir)